-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Update manifest format_version to 3.0.0 for cloud_security_posture package #8162
[Cloud Security] Update manifest format_version to 3.0.0 for cloud_security_posture package #8162
Conversation
🌐 Coverage report
|
c0e62c0
to
53be56a
Compare
…ty_posture_format_version_to_3
@orestisfl I found an issue with specifying
I think this is because we have To not block the format_version update I will remove the lifecycle addition from this PR and summarise the problem in https://github.com/elastic/security-team/issues/7642 to do that as a follow-up. Adding data_retention for our data stream is not a must for serverless, we should be able to do it independent of the version update |
…ith findings_latest index
I tested the package by building it and installing it on the stack created via |
- name: availability_zone | ||
type: keyword | ||
- name: Security.security_groups | ||
type: object | ||
type: nested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your tests, have you verified that these fields work as expected with the new type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I didn't find anything weird about them. They show up in the document, and flyout Table/JSON view works, but searching doesn't work with these fields as it doesn't work without the change either, I guess because they are not being indexed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just checked integrity using elastic-package check
and tested Kibana works properly using elastic-package stack
Package cloud_security_posture - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Proposed commit message
making necessary changes to update
cloud_security_posture
package format_version to 3.0.0 to opt in it for serverless:type: object
field mappings either to more suitable types or addedobject_type
as it's required nowadded DLM data_retention of 180d for findings index to enable data retention in serverless as ILM is not supported in serverlessdue to the issue will be handled separately as a part of https://github.com/elastic/security-team/issues/7642security
capability so the package shows up in serverlessChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package
and runelastic-package check
insidecloud_security_posture
package to validateRelated issues
Screenshots