Handle conflicts (#16682)

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/edit_index_pattern.html

@@ -23,10 +23,7 @@
       </p>
 
       <p class="kuiText kuiVerticalRhythm">
-        This page lists every field in the <strong>{{::indexPattern.title}}</strong>
-        index and the field's associated core type as recorded by Elasticsearch.
-        While this list allows you to view the core type of each field, changing
-        field types must be done using Elasticsearch's
+        This page lists every field in the <strong>{{::indexPattern.title}}</strong> index and the field's associated core type as recorded by Elasticsearch. To change a field type, use the Elasticsearch
         <a target="_window" class="euiLink euiLink--primary" href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping.html">
           Mapping API
           <i aria-hidden="true" class="fa-link fa"></i>
@@ -145,10 +142,7 @@
           class="fields indexed-fields"
         ></indexed-fields-table>
 
-        <scripted-fields-table
-          ng-show="state.tab == 'scriptedFields'"
-          class="fields scripted-fields"
-        ></scripted-fields-table>
+        <div id="reactScriptedFieldsTable"></div>
 
         <source-filters-table
           ng-show="state.tab == 'sourceFilters'"

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/edit_index_pattern.js

@@ -1,7 +1,6 @@
 import _ from 'lodash';
 import './index_header';
 import './indexed_fields_table';
-import './scripted_fields_table';
 import './scripted_field_editor';
 import './source_filters_table';
 import { KbnUrlProvider } from 'ui/url';
@@ -11,6 +10,50 @@ import uiRoutes from 'ui/routes';
 import { uiModules } from 'ui/modules';
 import template from './edit_index_pattern.html';
 
+import React from 'react';
+import { render, unmountComponentAtNode } from 'react-dom';
+import { ScriptedFieldsTable } from './scripted_fields_table';
+
+const REACT_SCRIPTED_FIELDS_DOM_ELEMENT_ID = 'reactScriptedFieldsTable';
+
+function updateScriptedFieldsTable($scope, $state) {
+  if ($state.tab === 'scriptedFields') {
+    $scope.$$postDigest(() => {
+      const node = document.getElementById(REACT_SCRIPTED_FIELDS_DOM_ELEMENT_ID);
+      if (!node) {
+        return;
+      }
+
+      render(
+        <ScriptedFieldsTable
+          indexPattern={$scope.indexPattern}
+          fieldFilter={$scope.fieldFilter}
+          scriptedFieldLanguageFilter={$scope.scriptedFieldLanguageFilter}
+          helpers={{
+            redirectToRoute: (obj, route) => {
+              $scope.kbnUrl.redirectToRoute(obj, route);
+              $scope.$apply();
+            },
+            getRouteHref: (obj, route) => $scope.kbnUrl.getRouteHref(obj, route),
+          }}
+          onRemoveField={() => {
+            $scope.editSections = $scope.editSectionsProvider($scope.indexPattern);
+            $scope.refreshFilters();
+          }}
+        />,
+        node,
+      );
+    });
+  } else {
+    destroyScriptedFieldsTable();
+  }
+}
+
+function destroyScriptedFieldsTable() {
+  const node = document.getElementById(REACT_SCRIPTED_FIELDS_DOM_ELEMENT_ID);
+  node && unmountComponentAtNode(node);
+}
+
 uiRoutes
   .when('/management/kibana/indices/:indexPatternId', {
     template,
@@ -45,6 +88,7 @@ uiModules.get('apps/management')
     const notify = new Notifier();
     const $state = $scope.state = new AppState();
 
+    $scope.editSectionsProvider = Private(IndicesEditSectionsProvider);
     $scope.kbnUrl = Private(KbnUrlProvider);
     $scope.indexPattern = $route.current.locals.indexPattern;
     docTitle.change($scope.indexPattern.title);
@@ -54,7 +98,7 @@ uiModules.get('apps/management')
     });
 
     $scope.$watch('indexPattern.fields', function () {
-      $scope.editSections = Private(IndicesEditSectionsProvider)($scope.indexPattern);
+      $scope.editSections = $scope.editSectionsProvider($scope.indexPattern);
       $scope.refreshFilters();
     });
 
@@ -79,6 +123,7 @@ uiModules.get('apps/management')
 
     $scope.changeTab = function (obj) {
       $state.tab = obj.index;
+      updateScriptedFieldsTable($scope, $state);
       $state.save();
     };
 
@@ -140,4 +185,22 @@ uiModules.get('apps/management')
       $scope.indexPattern.timeFieldName = field.name;
       return $scope.indexPattern.save();
     };
+
+    $scope.$watch('fieldFilter', () => {
+      if ($scope.fieldFilter !== undefined && $state.tab === 'scriptedFields') {
+        updateScriptedFieldsTable($scope, $state);
+      }
+    });
+
+    $scope.$watch('scriptedFieldLanguageFilter', () => {
+      if ($scope.scriptedFieldLanguageFilter !== undefined && $state.tab === 'scriptedFields') {
+        updateScriptedFieldsTable($scope, $state);
+      }
+    });
+
+    $scope.$on('$destory', () => {
+      destroyScriptedFieldsTable();
+    });
+
+    updateScriptedFieldsTable($scope, $state);
   });

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/edit_sections.js

@@ -15,17 +15,17 @@ export function IndicesEditSectionsProvider() {
 
     return [
       {
-        title: 'fields',
+        title: 'Fields',
         index: 'indexedFields',
         count: fieldCount.indexed
       },
       {
-        title: 'scripted fields',
+        title: 'Scripted fields',
         index: 'scriptedFields',
         count: fieldCount.scripted
       },
       {
-        title: 'source filters',
+        title: 'Source filters',
         index: 'sourceFilters',
         count: fieldCount.sourceFilters
       }