Change to RegExp

elastic · Feb 8, 2021 · 058a9bc · 058a9bc
1 parent ad932e4
commit 058a9bc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/jira/schema.ts b/x-pack/plugins/actions/server/builtin_action_types/jira/schema.ts
@@ -44,7 +44,8 @@ export const ExecutorSubActionPushParamsSchema = schema.object({
       schema.arrayOf(
         schema.string({
           validate: (label) =>
-            label.includes(' ') ? `The label ${label} cannot contain spaces` : undefined,
+            // Matches any space, tab or newline character.
+            label.match(/\s/g) ? `The label ${label} cannot contain spaces` : undefined,
         })
       )
     ),

diff --git a/...gins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.tsx b/...gins/triggers_actions_ui/public/application/components/builtin_action_types/jira/jira.tsx
@@ -87,7 +87,7 @@ export function getActionType(): ActionTypeModel<JiraConfig, JiraSecrets, JiraAc
 
       if (actionParams.subActionParams?.incident?.labels?.length) {
         // Jira do not allows empty spaces on labels. If the label includes a whitespace show an error.
-        if (actionParams.subActionParams.incident.labels.some((label) => label.includes(' ')))
+        if (actionParams.subActionParams.incident.labels.some((label) => label.match(/\s/g)))
           errors['subActionParams.incident.labels'].push(i18n.LABELS_WHITE_SPACES);
       }
       return validationResult;