test: 💍 make tests green again

elastic · Jun 26, 2020 · 06b7743 · 06b7743
1 parent 8c2e4e3
commit 06b7743
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 7 deletions.
diff --git a/...k/plugins/discover_enhanced/public/actions/explore_data/explore_data_chart_action.test.ts b/...k/plugins/discover_enhanced/public/actions/explore_data/explore_data_chart_action.test.ts
@@ -139,9 +139,16 @@ describe('"Explore underlying data" panel action', () => {
       expect(isCompatible).toBe(false);
     });
 
-    test('returns false if embeddable is not Visualize embeddable', async () => {
-      const { action, embeddable, context } = setup();
-      (embeddable as any).type = 'NOT_VISUALIZE_EMBEDDABLE';
+    test('returns false if embeddable has more than one index pattern', async () => {
+      const { action, output, context } = setup();
+      output.indexPatterns = [
+        {
+          id: 'index-ptr-foo',
+        },
+        {
+          id: 'index-ptr-bar',
+        },
+      ];
 
       const isCompatible = await action.isCompatible(context);
 

diff --git a/...ns/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.test.ts b/...ns/discover_enhanced/public/actions/explore_data/explore_data_context_menu_action.test.ts
@@ -125,9 +125,16 @@ describe('"Explore underlying data" panel action', () => {
       expect(isCompatible).toBe(false);
     });
 
-    test('returns false if embeddable is not Visualize embeddable', async () => {
-      const { action, embeddable, context } = setup();
-      (embeddable as any).type = 'NOT_VISUALIZE_EMBEDDABLE';
+    test('returns false if embeddable has more than one index pattern', async () => {
+      const { action, output, context } = setup();
+      output.indexPatterns = [
+        {
+          id: 'index-ptr-foo',
+        },
+        {
+          id: 'index-ptr-bar',
+        },
+      ];
 
       const isCompatible = await action.isCompatible(context);
 

diff --git a/x-pack/plugins/discover_enhanced/public/actions/explore_data/shared.ts b/x-pack/plugins/discover_enhanced/public/actions/explore_data/shared.ts
@@ -20,5 +20,5 @@ export const getIndexPatterns = (embeddable?: IEmbeddable): string[] => {
   return isOutputWithIndexPatterns(output) ? output.indexPatterns.map(({ id }) => id) : [];
 };
 
-export const hasExactlyOneIndexPattern = (embeddable?: IEmbeddable): string[] =>
+export const hasExactlyOneIndexPattern = (embeddable?: IEmbeddable): boolean =>
   getIndexPatterns(embeddable).length === 1;