Skip to content

Commit

Permalink
x-pack functional fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
thompsongl committed Oct 29, 2019
1 parent b313c0f commit 0cc7a2e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion x-pack/test/functional/page_objects/upgrade_assistant.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function UpgradeAssistantProvider({ getService, getPageObjects }) {
async expectDeprecationLoggingLabel(labelText) {
return await retry.try(async () => {
log.debug('expectDeprecationLoggingLabel()');
const label = await find.byCssSelector('[data-test-subj="upgradeAssistantDeprecationToggle"] ~ label');
const label = await find.byCssSelector('[data-test-subj="upgradeAssistantDeprecationToggle"] ~ p');
const value = await label.getVisibleText();
expect(value).to.equal(labelText);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,12 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
sectionOptions: SectionOptions = { withAdvancedSection: true }
): Promise<boolean> {
let subj = 'mlJobWizardSwitchModelPlot';
const isSelected = await testSubjects.getAttribute(subj, 'aria-checked');
if (sectionOptions.withAdvancedSection === true) {
await this.ensureAdvancedSectionOpen();
subj = advancedSectionSelector(subj);
}
return await testSubjects.isSelected(subj);
return isSelected === 'true';
},

async assertModelPlotSwitchCheckedState(
Expand Down Expand Up @@ -213,11 +214,12 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
sectionOptions: SectionOptions = { withAdvancedSection: true }
): Promise<boolean> {
let subj = 'mlJobWizardSwitchUseDedicatedIndex';
const isSelected = await testSubjects.getAttribute(subj, 'aria-checked');
if (sectionOptions.withAdvancedSection === true) {
await this.ensureAdvancedSectionOpen();
subj = advancedSectionSelector(subj);
}
return await testSubjects.isSelected(subj);
return isSelected === 'true';
},

async assertDedicatedIndexSwitchCheckedState(
Expand Down

0 comments on commit 0cc7a2e

Please sign in to comment.