Skip to content

Commit

Permalink
Fix regression in our ml usage collection (#81945) (#81960)
Browse files Browse the repository at this point in the history
A regression was introduced in #74965 that caused an error to be
thrown while collecting telemetry on ML jobs. Because such exceptions
are caught and we degrade to zeroing out those counts, this one was not
caught until manual testing of telemetry.
  • Loading branch information
rylnd authored Oct 29, 2020
1 parent 31b0292 commit 15bc17f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export const getMlJobsUsage = async (ml: MlPluginSetup | undefined): Promise<MlJ

if (ml) {
try {
const fakeRequest = {} as KibanaRequest;
const fakeRequest = { headers: {} } as KibanaRequest;
const fakeSOClient = {} as SavedObjectsClient;

const modules = await ml.modulesProvider(fakeRequest, fakeSOClient).listModules();
Expand Down

0 comments on commit 15bc17f

Please sign in to comment.