nits

elastic · Feb 4, 2020 · 1623d8e · 1623d8e
1 parent abc1f8d
commit 1623d8e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/core/server/saved_objects/mappings/types.ts b/src/core/server/saved_objects/mappings/types.ts
@@ -97,6 +97,9 @@ export interface SavedObjectsMappingProperties {
 /**
  * Describe a {@link SavedObjectsTypeMappingDefinition | saved object type mapping} field.
  *
+ * Please refer to {@link https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html | elasticsearch documentation}
+ * For the mapping documentation
+ *
  * @public
  */
 export type SavedObjectsFieldMapping =
@@ -118,7 +121,11 @@ export interface IndexMappingMeta {
   migrationMappingPropertyHashes?: { [k: string]: string };
 }
 
-/** @public */
+/**
+ * See {@link SavedObjectsFieldMapping} for documentation.
+ *
+ * @public
+ */
 export interface SavedObjectsCoreFieldMapping {
   type: string;
   index?: boolean;
@@ -130,7 +137,11 @@ export interface SavedObjectsCoreFieldMapping {
   };
 }
 
-/** @public */
+/**
+ * See {@link SavedObjectsFieldMapping} for documentation.
+ *
+ * @public
+ */
 export interface SavedObjectsComplexFieldMapping {
   dynamic?: string;
   type?: string;

diff --git a/src/core/server/saved_objects/serialization/serializer.ts b/src/core/server/saved_objects/serialization/serializer.ts
@@ -50,10 +50,10 @@ export class SavedObjectsSerializer {
     const { type, namespace } = rawDoc._source;
     const namespacePrefix =
       namespace && !this.registry.isNamespaceAgnostic(type) ? `${namespace}:` : '';
-    return (
+    return Boolean(
       type &&
-      rawDoc._id.startsWith(`${namespacePrefix}${type}:`) &&
-      rawDoc._source.hasOwnProperty(type)
+        rawDoc._id.startsWith(`${namespacePrefix}${type}:`) &&
+        rawDoc._source.hasOwnProperty(type)
     );
   }