Fixed useEffect in metric_axes. Update type in params instead of type…

… of vis
elastic · Sep 25, 2020 · 23634a6 · 23634a6
1 parent f2fc48d
commit 23634a6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx b/src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx
@@ -299,8 +299,8 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
   }, [stateParams.seriesParams]);
 
   useEffect(() => {
-    vis.setState({ ...vis.serialize(), type: visType });
-  }, [vis, visType]);
+    setValue('type', visType);
+  }, [setValue, visType]);
 
   return isTabSelected ? (
     <>

diff --git a/src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx b/src/plugins/vis_type_vislib/public/components/options/point_series/point_series.tsx
@@ -68,7 +68,7 @@ function PointSeriesOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
           />
         )}
 
-        {vis.type.name === ChartTypes.HISTOGRAM && (
+        {stateParams.type === ChartTypes.HISTOGRAM && (
           <SwitchOption
             data-test-subj="showValuesOnChart"
             label={i18n.translate('visTypeVislib.editors.pointSeries.showLabels', {

diff --git a/src/plugins/vis_type_vislib/public/types.ts b/src/plugins/vis_type_vislib/public/types.ts
@@ -93,4 +93,5 @@ export interface BasicVislibParams extends CommonVislibParams {
   };
   seriesParams: SeriesParam[];
   times: TimeMarker[];
+  type: string;
 }