Fixed types.

elastic · May 26, 2022 · 273d280 · 273d280
1 parent c17cf37
commit 273d280
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis_fn.ts b/src/plugins/chart_expressions/expression_xy/common/expression_functions/layered_xy_vis_fn.ts
@@ -42,7 +42,6 @@ export const layeredXyVisFn: LayeredXyVisFn['fn'] = async (data, args, handlers)
       args: {
         ...args,
         layers,
-        showTooltip: args.showTooltip ?? false,
         markSizeRatio: hasMarkSizeAccessors && !args.markSizeRatio ? 10 : args.markSizeRatio,
         ariaLabel:
           args.ariaLabel ??

diff --git a/src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts b/src/plugins/chart_expressions/expression_xy/common/expression_functions/xy_vis_fn.ts
@@ -142,7 +142,6 @@ export const xyVisFn: XyVisFn['fn'] = async (data, args, handlers) => {
       args: {
         ...restArgs,
         layers,
-        showTooltip: args.showTooltip ?? false,
         markSizeRatio:
           dataLayers[0].markSizeAccessor && !args.markSizeRatio ? 10 : args.markSizeRatio,
         ariaLabel:

diff --git a/src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts b/src/plugins/chart_expressions/expression_xy/common/types/expression_functions.ts
@@ -221,7 +221,7 @@ export interface XYArgs extends DataLayerArgs {
   splitRowAccessor?: ExpressionValueVisDimension | string;
   splitColumnAccessor?: ExpressionValueVisDimension | string;
   orderBucketsBySum?: boolean;
-  showTooltip?: boolean;
+  showTooltip: boolean;
 }
 
 export interface LayeredXYArgs {
@@ -251,7 +251,7 @@ export interface LayeredXYArgs {
   markSizeRatio?: number;
   minTimeBarInterval?: string;
   orderBucketsBySum?: boolean;
-  showTooltip?: boolean;
+  showTooltip: boolean;
 }
 
 export interface XYProps {
@@ -283,7 +283,7 @@ export interface XYProps {
   splitRowAccessor?: ExpressionValueVisDimension | string;
   splitColumnAccessor?: ExpressionValueVisDimension | string;
   orderBucketsBySum?: boolean;
-  showTooltip?: boolean;
+  showTooltip: boolean;
 }
 
 export interface AnnotationLayerArgs {

diff --git a/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx b/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.test.tsx
@@ -2236,6 +2236,7 @@ describe('XYChart component', () => {
       yRightTitle: '',
       yLeftScale: 'linear',
       yRightScale: 'linear',
+      showTooltip: true,
       legend: { type: 'legendConfig', isVisible: false, position: Position.Top },
       valueLabels: 'hide',
       tickLabelsVisibilitySettings: {
@@ -2328,6 +2329,7 @@ describe('XYChart component', () => {
       yRightTitle: '',
       legend: { type: 'legendConfig', isVisible: false, position: Position.Top },
       valueLabels: 'hide',
+      showTooltip: true,
       tickLabelsVisibilitySettings: {
         type: 'tickLabelsConfig',
         x: true,
@@ -2401,6 +2403,7 @@ describe('XYChart component', () => {
       xTitle: '',
       yTitle: '',
       yRightTitle: '',
+      showTooltip: true,
       legend: { type: 'legendConfig', isVisible: true, position: Position.Top },
       valueLabels: 'hide',
       tickLabelsVisibilitySettings: {