added lens by value tests, started maps by value

x-pack/test/functional/apps/dashboard/dashboard_lens_by_value.ts

@@ -0,0 +1,101 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getPageObjects, getService }: FtrProviderContext) {
+  const PageObjects = getPageObjects(['common', 'dashboard', 'visualize', 'lens']);
+
+  const log = getService('log');
+  const find = getService('find');
+  const esArchiver = getService('esArchiver');
+  const dashboardPanelActions = getService('dashboardPanelActions');
+  const dashboardVisualizations = getService('dashboardVisualizations');
+
+  async function createAndAddLensByValue() {
+    log.debug(`createAndAddLensByValue`);
+    const inViewMode = await PageObjects.dashboard.getIsInViewMode();
+    if (inViewMode) {
+      await PageObjects.dashboard.switchToEditMode();
+    }
+    await PageObjects.visualize.clickLensWidget();
+    await PageObjects.lens.goToTimeRange();
+    await PageObjects.lens.configureDimension({
+      dimension: 'lnsXY_xDimensionPanel > lns-empty-dimension',
+      operation: 'date_histogram',
+      field: '@timestamp',
+    });
+
+    await PageObjects.lens.configureDimension({
+      dimension: 'lnsXY_yDimensionPanel > lns-empty-dimension',
+      operation: 'avg',
+      field: 'bytes',
+    });
+
+    await PageObjects.lens.configureDimension({
+      dimension: 'lnsXY_splitDimensionPanel > lns-empty-dimension',
+      operation: 'terms',
+      field: 'ip',
+    });
+    await PageObjects.lens.saveAndReturn();
+  }
+
+  describe('dashboard lens by value', function () {
+    before(async () => {
+      await esArchiver.loadIfNeeded('logstash_functional');
+      await esArchiver.loadIfNeeded('lens/basic');
+      await PageObjects.common.navigateToApp('dashboard');
+      await PageObjects.dashboard.preserveCrossAppState();
+      await PageObjects.dashboard.clickNewDashboard();
+    });
+
+    it('can add a lens panel by value', async () => {
+      await dashboardVisualizations.ensureNewVisualizationDialogIsShowing();
+      await createAndAddLensByValue();
+      const newPanelCount = await PageObjects.dashboard.getPanelCount();
+      expect(newPanelCount).to.eql(1);
+    });
+
+    it('edits to a by value lens panel are properly applied', async () => {
+      await PageObjects.dashboard.waitForRenderComplete();
+      await dashboardPanelActions.openContextMenu();
+      await dashboardPanelActions.clickEdit();
+      await PageObjects.lens.switchToVisualization('donut');
+      await PageObjects.lens.saveAndReturn();
+      await PageObjects.dashboard.waitForRenderComplete();
+
+      const pieExists = await find.existsByCssSelector('.lnsPieExpression__container');
+      expect(pieExists).to.be(true);
+    });
+
+    it('editing and saving a lens by value panel retains number of panels', async () => {
+      const originalPanelCount = await PageObjects.dashboard.getPanelCount();
+      await PageObjects.dashboard.waitForRenderComplete();
+      await dashboardPanelActions.openContextMenu();
+      await dashboardPanelActions.clickEdit();
+      await PageObjects.lens.switchToVisualization('treemap');
+      await PageObjects.lens.saveAndReturn();
+      await PageObjects.dashboard.waitForRenderComplete();
+      const newPanelCount = await PageObjects.dashboard.getPanelCount();
+      expect(newPanelCount).to.eql(originalPanelCount);
+    });
+
+    it('updates panel on dashboard when a by value panel is saved to library', async () => {
+      const newTitle = 'look out library, here I come!';
+      const originalPanelCount = await PageObjects.dashboard.getPanelCount();
+      await PageObjects.dashboard.waitForRenderComplete();
+      await dashboardPanelActions.openContextMenu();
+      await dashboardPanelActions.clickEdit();
+      await PageObjects.lens.save(newTitle, false, true);
+      await PageObjects.dashboard.waitForRenderComplete();
+      const newPanelCount = await PageObjects.dashboard.getPanelCount();
+      expect(newPanelCount).to.eql(originalPanelCount);
+      const titles = await PageObjects.dashboard.getPanelTitles();
+      expect(titles.indexOf(newTitle)).to.not.be(-1);
+    });
+  });
+}

x-pack/test/functional/apps/dashboard/dashboard_maps_by_value.ts

@@ -0,0 +1,43 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getPageObjects, getService }: FtrProviderContext) {
+  const PageObjects = getPageObjects(['common', 'dashboard', 'visualize', 'maps']);
+
+  const log = getService('log');
+  const esArchiver = getService('esArchiver');
+  const dashboardVisualizations = getService('dashboardVisualizations');
+
+  async function createAndAddMapByValue() {
+    log.debug(`createAndAddMapByValue`);
+    const inViewMode = await PageObjects.dashboard.getIsInViewMode();
+    if (inViewMode) {
+      await PageObjects.dashboard.switchToEditMode();
+    }
+    await PageObjects.visualize.clickMapsApp();
+    await PageObjects.maps.clickSaveAndReturnButton();
+  }
+
+  describe('dashboard maps by value', function () {
+    before(async () => {
+      await esArchiver.loadIfNeeded('logstash_functional');
+      await esArchiver.loadIfNeeded('lens/basic');
+      await PageObjects.common.navigateToApp('dashboard');
+      await PageObjects.dashboard.preserveCrossAppState();
+      await PageObjects.dashboard.clickNewDashboard();
+    });
+
+    it('can add a map by value', async () => {
+      await dashboardVisualizations.ensureNewVisualizationDialogIsShowing();
+      await createAndAddMapByValue();
+      const newPanelCount = await PageObjects.dashboard.getPanelCount();
+      expect(newPanelCount).to.eql(1);
+    });
+  });
+}

x-pack/test/functional/apps/dashboard/index.ts

@@ -15,5 +15,7 @@ export default function ({ loadTestFile }: FtrProviderContext) {
     loadTestFile(require.resolve('./drilldowns'));
     loadTestFile(require.resolve('./sync_colors'));
     loadTestFile(require.resolve('./_async_dashboard'));
+    loadTestFile(require.resolve('./dashboard_lens_by_value'));
+    loadTestFile(require.resolve('./dashboard_maps_by_value'));
   });
 }