[SIEM] Use proper icons on Detections view (#55215) (#55297)

elastic · Jan 20, 2020 · 3e6c1e0 · 3e6c1e0
1 parent f6c882e
commit 3e6c1e0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx b/x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx
@@ -42,6 +42,10 @@ const WrappedByAutoSizer = styled.div`
 `; // required by AutoSizer
 WrappedByAutoSizer.displayName = 'WrappedByAutoSizer';
 
+const StyledEuiPanel = styled(EuiPanel)`
+  max-width: 100%;
+`;
+
 interface Props {
   browserFields: BrowserFields;
   columns: ColumnHeader[];
@@ -113,7 +117,7 @@ const EventsViewerComponent: React.FC<Props> = ({
   );
 
   return (
-    <EuiPanel data-test-subj="events-viewer-panel">
+    <StyledEuiPanel data-test-subj="events-viewer-panel">
       <AutoSizer detectAnyWindowResize={true} content>
         {({ measureRef, content: { width = 0 } }) => (
           <>
@@ -225,7 +229,7 @@ const EventsViewerComponent: React.FC<Props> = ({
           </>
         )}
       </AutoSizer>
-    </EuiPanel>
+    </StyledEuiPanel>
   );
 };
 

diff --git a/...k/legacy/plugins/siem/public/pages/detection_engine/components/signals/default_config.tsx b/...k/legacy/plugins/siem/public/pages/detection_engine/components/signals/default_config.tsx
@@ -188,13 +188,13 @@ export const getSignalsActions = ({
   updateTimelineIsLoading: ({ id, isLoading }: { id: string; isLoading: boolean }) => void;
 }): TimelineAction[] => [
   {
-    getAction: ({ eventId, ecsData }: TimelineActionProps): JSX.Element => (
+    getAction: ({ ecsData }: TimelineActionProps): JSX.Element => (
       <EuiToolTip
         data-test-subj="send-signal-to-timeline-tool-tip"
         content={i18n.ACTION_VIEW_IN_TIMELINE}
       >
         <EuiButtonIcon
-          data-test-subj={'send-signal-to-timeline-button'}
+          data-test-subj="send-signal-to-timeline-button"
           onClick={() =>
             sendSignalToTimelineAction({
               apolloClient,
@@ -203,7 +203,7 @@ export const getSignalsActions = ({
               updateTimelineIsLoading,
             })
           }
-          iconType="tableDensityNormal"
+          iconType="timeline"
           aria-label="Next"
         />
       </EuiToolTip>
@@ -228,7 +228,7 @@ export const getSignalsActions = ({
             })
           }
           isDisabled={!canUserCRUD || !hasIndexWrite}
-          iconType={status === FILTER_OPEN ? 'indexOpen' : 'indexClose'}
+          iconType={status === FILTER_OPEN ? 'securitySignalDetected' : 'securitySignalResolved'}
           aria-label="Next"
         />
       </EuiToolTip>

diff --git a/...em/public/pages/detection_engine/components/signals/signals_utility_bar/batch_actions.tsx b/...em/public/pages/detection_engine/components/signals/signals_utility_bar/batch_actions.tsx
@@ -61,7 +61,7 @@ export const getBatchItems = ({
 
     <EuiContextMenuItem
       key={filterString}
-      icon={isFilteredToOpen ? 'indexClose' : 'indexOpen'}
+      icon={isFilteredToOpen ? 'securitySignalResolved' : 'securitySignalDetected'}
       disabled={allDisabled}
       onClick={async () => {
         closePopover();

diff --git a/...ugins/siem/public/pages/detection_engine/components/signals/signals_utility_bar/index.tsx b/...ugins/siem/public/pages/detection_engine/components/signals/signals_utility_bar/index.tsx
@@ -80,7 +80,7 @@ const SignalsUtilityBarComponent: React.FC<SignalsUtilityBarProps> = ({
 
                 <UtilityBarAction
                   disabled={areEventsLoading || isEmpty(selectedEventIds)}
-                  iconType={isFilteredToOpen ? 'indexClose' : 'indexOpen'}
+                  iconType={isFilteredToOpen ? 'securitySignalResolved' : 'securitySignalDetected'}
                   onClick={handleUpdateStatus}
                 >
                   {isFilteredToOpen
@@ -89,7 +89,7 @@ const SignalsUtilityBarComponent: React.FC<SignalsUtilityBarProps> = ({
                 </UtilityBarAction>
 
                 <UtilityBarAction
-                  iconType="listAdd"
+                  iconType={showClearSelection ? 'cross' : 'pagesSelect'}
                   onClick={() => {
                     if (!showClearSelection) {
                       selectAll();