Replace role=main by main elements (#12671)

* Replace role=main by main elements * Move main style to _common_styles * Add compiled UI Framework CSS.
elastic · Jul 12, 2017 · 3fe58e9 · 3fe58e9
1 parent dee4f7d
commit 3fe58e9
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 7 deletions.
diff --git a/src/core_plugins/kibana/public/context/app.html b/src/core_plugins/kibana/public/context/app.html
@@ -52,10 +52,9 @@
   </div>
 </div>
 
-<div
+<main
   class="kuiViewContent kuiViewContentItem"
   ng-if="contextApp.state.loadingStatus.anchor.status !== contextApp.constants.LOADING_STATUS.FAILED"
-  role="main"
 >
   <!-- Controls -->
   <div class="kuiBar kuiVerticalRhythm">
@@ -157,4 +156,4 @@
     <div class="kuiBarSection">
     </div>
   </div>
-</div>
+</main>
diff --git a/src/core_plugins/kibana/public/dev_tools/partials/dev_tools_app.html b/src/core_plugins/kibana/public/dev_tools/partials/dev_tools_app.html
@@ -21,5 +21,5 @@
       </div>
     </div>
   </kbn-top-nav>
-  <div role="main" class="dev-tools__container" ng-transclude></div>
+  <main class="dev-tools__container" ng-transclude></main>
 </div>
diff --git a/src/core_plugins/kibana/public/discover/index.html b/src/core_plugins/kibana/public/discover/index.html
@@ -64,7 +64,7 @@ <h1 tabindex="0" id="kui_local_breadcrumb" class="kuiLocalBreadcrumb">
     </div>
   </kbn-top-nav>
 
-  <div class="container-fluid" role="main">
+  <main class="container-fluid">
     <div class="row">
       <filter-bar
         state="state"
@@ -182,5 +182,5 @@ <h2>Searching</h2>
         </div>
       </div>
     </div>
-  </div>
+  </main>
 </discover-app>
diff --git a/src/core_plugins/kibana/public/management/app.html b/src/core_plugins/kibana/public/management/app.html
@@ -35,5 +35,5 @@
     </div>
   </kbn-top-nav>
 
-  <div role="main" class="management-container" ng-transclude></div>
+  <main class="management-container" ng-transclude></main>
 </div>
diff --git a/ui_framework/components/_common_styles.scss b/ui_framework/components/_common_styles.scss
@@ -15,3 +15,10 @@
 body {
   font-family: $globalFontFamily;
 }
+
+/**
+ * 1. Required for IE11.
+ */
+main {
+  display: block; /* 1 */
+}
diff --git a/ui_framework/dist/ui_framework.css b/ui_framework/dist/ui_framework.css
@@ -69,6 +69,13 @@
 body {
   font-family: "Open Sans", Helvetica, Arial, sans-serif; }
 
+/**
+ * 1. Required for IE11.
+ */
+main {
+  display: block;
+  /* 1 */ }
+
 .kuiActionItem {
   display: -webkit-box;
   display: -webkit-flex;