Cleanup

elastic · Feb 22, 2023 · 4068038 · 4068038
1 parent 0fc1962
commit 4068038
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/plugins/data_views/common/data_views/data_views.test.ts b/src/plugins/data_views/common/data_views/data_views.test.ts
@@ -212,9 +212,6 @@ describe('IndexPatterns', () => {
 
   test('allowNoIndex flag preserves existing fields when index is missing', async () => {
     const id = '2';
-    apiClient.getFieldsForWildcard = jest.fn().mockImplementation(async () => {
-      throw new DataViewMissingIndices('Catch me if you can!');
-    });
     setDocsourcePayload(id, {
       id: 'foo',
       version: 'foo',

diff --git a/src/plugins/data_views/common/data_views/data_views.ts b/src/plugins/data_views/common/data_views/data_views.ts
@@ -104,7 +104,8 @@ export interface DataViewsServiceDeps {
    */
   onNotification: OnNotification;
   /**
-   * Handler when there are missing indices
+   * Handler triggered when there are no indices
+   * @param error Error object
    */
   onMissingIndices?: (error: Error) => void;
   /**
@@ -338,10 +339,10 @@ export class DataViewsService {
       apiClient,
       fieldFormats,
       onNotification,
+      onMissingIndices,
       onError,
       getCanSave = () => Promise.resolve(false),
       getCanSaveAdvancedSettings,
-      onMissingIndices,
     } = deps;
     this.apiClient = apiClient;
     this.config = uiSettings;
@@ -646,6 +647,9 @@ export class DataViewsService {
         this.onMissingIndices?.(err);
         return {};
       }
+      if (!displayErrors) {
+        throw err;
+      }
 
       this.onError(
         err,