Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisronline committed Dec 22, 2017
1 parent 8eec626 commit 47b245c
Show file tree
Hide file tree
Showing 3 changed files with 215 additions and 188 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,21 @@
class="kuiViewContent"
>
<!-- Intro -->
<h1 class="euiTitle">
<h1 class="euiTitle euiTitle--medium">
Create index pattern
</h1>
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--responsive">
<p class="euiFlexItem euiFlexItem--flexGrowZero euiTextColor euiTextColor--subdued">
Kibana uses index patterns to retrieve data from Elasticsearch indices for things like visualizations.
</p>

<div class="euiSpacer euiSpacer--small"></div>

<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--alignItemsEnd euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<div class="euiText">
<p class="euiTextColor euiTextColor--subdued">
Kibana uses index patterns to retrieve data from Elasticsearch indices for things like visualizations.
</p>
</div>
</div>

<div class="euiFlexItem euiFlexItem--flexGrowZero">
<label
ng-if="controller.isSystemIndicesCheckBoxVisible()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,47 +10,48 @@ <h2 class="euiTitle">
role="form"
ng-submit="stepIndexPattern.goToNextStep()"
>
<div class="euiFormRow">
<label
for="indexPatternNameField"
class="euiFormLabel"
>
Index pattern
</label>
<div class="euiFormControlLayout">
<!-- Index pattern input -->
<input
id="indexPatternNameField"
class="euiFieldText euiFieldText--fullWidth createIndexPatternInputField"
data-test-subj="createIndexPatternNameInput"
ng-model="stepIndexPattern.indexPatternName"
placeholder="index-name-*"
validate-index-pattern
validate-index-pattern-allow-wildcard
append-wildcard
name="name"
required
type="text"
aria-describedby="indexPatternNameFieldHelp1 indexPatternNameFieldHelp2"
>
</div>
</div>
<div class="euiSpacer euiSpacer--xs"></div>
<div class="euiFlexGroup">
<div class="euiFlexItem">
<p
id="indexPatternNameFieldHelp1"
class="euiTextColor euiTextColor--subdued"
>
You can use a <strong>*</strong> as a wildcard in your index pattern.
</p>
<div class="euiSpacer euiSpacer--xs"></div>
<p
id="indexPatternNameFieldHelp2"
class="euiTextColor euiTextColor--subdued"
>
You can't use empty spaces or the characters <strong>\ / ? " < > |</strong>.
</p>
<div class="euiFlexGroup euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--alignItemsEnd euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<div class="euiFormRow">
<label
for="indexPatternNameField"
class="euiFormLabel"
>
Index pattern
</label>
<div class="euiFormControlLayout">
<!-- Index pattern input -->
<input
id="indexPatternNameField"
class="euiFieldText euiFieldText--fullWidth createIndexPatternInputField"
data-test-subj="createIndexPatternNameInput"
ng-model="stepIndexPattern.indexPatternName"
placeholder="index-name-*"
validate-index-pattern
validate-index-pattern-allow-wildcard
append-wildcard
name="name"
required
type="text"
aria-describedby="indexPatternNameFieldHelp1 indexPatternNameFieldHelp2"
>
</div>
<div class="euiFormHelpText euiFormRow__text">
<p
id="indexPatternNameFieldHelp1"
class="euiTextColor euiTextColor--subdued"
>
You can use a <strong>*</strong> as a wildcard in your index pattern.
</p>
<div class="euiSpacer euiSpacer--xs"></div>
<p
id="indexPatternNameFieldHelp2"
class="euiTextColor euiTextColor--subdued"
>
You can't use empty spaces or the characters <strong>\ / ? " < > |</strong>.
</p>
</div>
</div>
</div>
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<!-- Action -->
Expand Down Expand Up @@ -105,14 +106,12 @@ <h2 class="euiTitle">
indices="stepIndexPattern.allIndices"
pattern="stepIndexPattern.indexPatternName"
>
<span class="euiTextColor euiTextColor--primary">
<span ng-if="!stepIndexPattern.allIndices.length">
You only have a single index. You can create an index pattern to match it.
</span>
<span ng-if="!stepIndexPattern.allIndices.length">
You only have a single index. You can create an index pattern to match it.
</span>

<span ng-if="stepIndexPattern.allIndices.length">
Your index pattern can match any of your <strong>{{stepIndexPattern.allIndices.length}} indices</strong>, below.
</span>
<span ng-if="stepIndexPattern.allIndices.length">
Your index pattern can match any of your <strong>{{stepIndexPattern.allIndices.length}} indices</strong>, below.
</span>
</matching-indices-list>
</div>
Expand Down
Loading

0 comments on commit 47b245c

Please sign in to comment.