[ML] Change file data visualizer JSON format label to NDJSON (#24643)

* [ML] Change file datavisualizer JSON format label to NDJSON * [ML] Update edit flyout overrides snapshot
elastic · Oct 29, 2018 · 4cc49be · 4cc49be
1 parent 9a158c1
commit 4cc49be
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/src/core_plugins/kibana/public/home/components/__snapshots__/add_data.test.js.snap b/src/core_plugins/kibana/public/home/components/__snapshots__/add_data.test.js.snap
@@ -832,7 +832,7 @@ exports[`mlEnabled 1`] = `
           type="button"
         >
           <FormattedMessage
-            defaultMessage="Import a JSON, CSV, or log file"
+            defaultMessage="Import a CSV, NDJSON, or log file"
             id="kbn.home.addData.uploadFileLink"
             values={Object {}}
           />

diff --git a/src/core_plugins/kibana/public/home/components/add_data.js b/src/core_plugins/kibana/public/home/components/add_data.js
@@ -229,7 +229,7 @@ const AddDataUi = ({ apmUiEnabled, isNewKibanaInstance, intl, mlEnabled }) => {
               >
                 <FormattedMessage
                   id="kbn.home.addData.uploadFileLink"
-                  defaultMessage="Import a JSON, CSV, or log file"
+                  defaultMessage="Import a CSV, NDJSON, or log file"
                 />
               </EuiLink>
             </EuiText>

diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js b/x-pack/plugins/ml/public/file_datavisualizer/components/about_panel/welcome_content.js
@@ -56,7 +56,7 @@ export function WelcomeContent() {
           <EuiFlexItem>
             <EuiText>
               <p>
-                JSON
+                Delimited text files, such as CSV and TSV
               </p>
             </EuiText>
           </EuiFlexItem>
@@ -69,7 +69,7 @@ export function WelcomeContent() {
           <EuiFlexItem>
             <EuiText>
               <p>
-                Delimited text files, such as CSV and TSV
+                Newline-delimited JSON
               </p>
             </EuiText>
           </EuiFlexItem>

diff --git a/...ml/public/file_datavisualizer/components/edit_flyout/__snapshots__/overrides.test.js.snap b/...ml/public/file_datavisualizer/components/edit_flyout/__snapshots__/overrides.test.js.snap
@@ -14,15 +14,15 @@ exports[`Overrides render overrides 1`] = `
         Array [
           Object {
             "inputDisplay": <span>
-              json
+              delimited
             </span>,
-            "value": "json",
+            "value": "delimited",
           },
           Object {
             "inputDisplay": <span>
-              delimited
+              ndjson
             </span>,
-            "value": "delimited",
+            "value": "ndjson",
           },
           Object {
             "inputDisplay": <span>

diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/edit_flyout/options/option_lists.js b/x-pack/plugins/ml/public/file_datavisualizer/components/edit_flyout/options/option_lists.js
@@ -6,8 +6,8 @@
 
 
 export const FORMAT_OPTIONS = [
-  'json',
   'delimited',
+  'ndjson',
   'semi_structured_text',
   'xml',
 ];

diff --git a/x-pack/plugins/ml/public/file_datavisualizer/components/file_datavisualizer_view/utils.js b/x-pack/plugins/ml/public/file_datavisualizer/components/file_datavisualizer_view/utils.js
@@ -65,7 +65,7 @@ export function createUrlOverrides(overrides, originalSettings) {
     }
   }
 
-  if (formattedOverrides.format === 'json' || originalSettings.format === 'json') {
+  if (formattedOverrides.format === 'ndjson' || originalSettings.format === 'ndjson') {
     formattedOverrides.should_trim_fields = '';
     formattedOverrides.has_header_row = '';
     formattedOverrides.delimiter = '';

diff --git a/...plugins/ml/public/file_datavisualizer/components/import_view/importer/importer_factory.js b/...plugins/ml/public/file_datavisualizer/components/import_view/importer/importer_factory.js
@@ -7,7 +7,7 @@
 
 import { CsvImporter } from './csv_importer';
 import { SstImporter } from './sst_importer';
-import { JsonImporter } from './json_importer';
+import { NdjsonImporter } from './ndjson_importer';
 
 export function importerFactory(format, results, settings) {
 
@@ -16,8 +16,8 @@ export function importerFactory(format, results, settings) {
       return new CsvImporter(results, settings);
     case 'semi_structured_text':
       return new SstImporter(results, settings);
-    case 'json':
-      return new JsonImporter(results, settings);
+    case 'ndjson':
+      return new NdjsonImporter(results, settings);
     default:
       return;
   }

diff --git a/...nts/import_view/importer/json_importer.js → ...s/import_view/importer/ndjson_importer.js b/...nts/import_view/importer/json_importer.js → ...s/import_view/importer/ndjson_importer.js
@@ -7,7 +7,7 @@
 
 import { Importer } from './importer';
 
-export class JsonImporter extends Importer {
+export class NdjsonImporter extends Importer {
   constructor(results, settings) {
     super(settings);
   }