addresses comments

elastic · Aug 17, 2020 · 4cf0023 · 4cf0023
1 parent 5ef03ec
commit 4cf0023
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 23 deletions.
diff --git a/.../security_solution/public/common/components/exceptions/add_exception_modal/index.test.tsx b/.../security_solution/public/common/components/exceptions/add_exception_modal/index.test.tsx
@@ -55,7 +55,7 @@ describe('When the add exception modal is opened', () => {
     }));
     (useAddOrUpdateException as jest.Mock).mockImplementation(() => [
       { isLoading: false },
-      () => {},
+      jest.fn(),
     ]);
     (useFetchOrCreateRuleExceptionList as jest.Mock).mockImplementation(() => [
       false,
@@ -96,8 +96,8 @@ describe('When the add exception modal is opened', () => {
             ruleIndices={[]}
             ruleName={ruleName}
             exceptionListType={'endpoint'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
           />
         </ThemeProvider>
       );
@@ -117,8 +117,8 @@ describe('When the add exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'endpoint'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
           />
         </ThemeProvider>
       );
@@ -157,8 +157,8 @@ describe('When the add exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'endpoint'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             alertData={alertDataMock}
           />
         </ThemeProvider>
@@ -208,8 +208,8 @@ describe('When the add exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'detection'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             alertData={alertDataMock}
           />
         </ThemeProvider>
@@ -276,8 +276,8 @@ describe('When the add exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'endpoint'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             alertData={alertDataMock}
           />
         </ThemeProvider>
@@ -290,7 +290,6 @@ describe('When the add exception modal is opened', () => {
         wrapper.find('button[data-test-subj="add-exception-confirm-button"]').getDOMNode()
       ).not.toBeDisabled();
     });
-
     it('should render the exception builder', () => {
       expect(wrapper.find('[data-test-subj="alert-exception-builder"]').exists()).toBeTruthy();
     });

diff --git a/...security_solution/public/common/components/exceptions/edit_exception_modal/index.test.tsx b/...security_solution/public/common/components/exceptions/edit_exception_modal/index.test.tsx
@@ -55,7 +55,7 @@ describe('When the edit exception modal is opened', () => {
     });
     (useAddOrUpdateException as jest.Mock).mockImplementation(() => [
       { isLoading: false },
-      () => {},
+      jest.fn(),
     ]);
     (useFetchIndexPatterns as jest.Mock).mockImplementation(() => [
       {
@@ -86,8 +86,8 @@ describe('When the edit exception modal is opened', () => {
             ruleIndices={[]}
             ruleName={ruleName}
             exceptionListType={'endpoint'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             exceptionItem={getExceptionListItemSchemaMock()}
           />
         </ThemeProvider>
@@ -114,8 +114,8 @@ describe('When the edit exception modal is opened', () => {
               ruleIndices={['filebeat-*']}
               ruleName={ruleName}
               exceptionListType={'endpoint'}
-              onCancel={() => {}}
-              onConfirm={() => {}}
+              onCancel={jest.fn()}
+              onConfirm={jest.fn()}
               exceptionItem={exceptionItemMock}
             />
           </ThemeProvider>
@@ -156,8 +156,8 @@ describe('When the edit exception modal is opened', () => {
               ruleIndices={['filebeat-*']}
               ruleName={ruleName}
               exceptionListType={'endpoint'}
-              onCancel={() => {}}
-              onConfirm={() => {}}
+              onCancel={jest.fn()}
+              onConfirm={jest.fn()}
               exceptionItem={getExceptionListItemSchemaMock()}
             />
           </ThemeProvider>
@@ -199,8 +199,8 @@ describe('When the edit exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'detection'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             exceptionItem={getExceptionListItemSchemaMock()}
           />
         </ThemeProvider>
@@ -238,8 +238,8 @@ describe('When the edit exception modal is opened', () => {
             ruleIndices={['filebeat-*']}
             ruleName={ruleName}
             exceptionListType={'detection'}
-            onCancel={() => {}}
-            onConfirm={() => {}}
+            onCancel={jest.fn()}
+            onConfirm={jest.fn()}
             exceptionItem={exceptionItemMock}
           />
         </ThemeProvider>