Fix types and i18n issue

elastic · Dec 13, 2024 · 5c51a73 · 5c51a73
1 parent 354775d
commit 5c51a73
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...on/public/detection_engine/rule_management/components/rule_details/rule_about_section.tsx b/...on/public/detection_engine/rule_management/components/rule_details/rule_about_section.tsx
@@ -303,7 +303,7 @@ const prepareAboutSectionListItems = (
       title: (
         <span data-test-subj="buildingBlockPropertyTitle">{i18n.BUILDING_BLOCK_FIELD_LABEL}</span>
       ),
-      description: <BuildingBlock isBuildingBlockEnabled={true} />,
+      description: <BuildingBlock type="default" />,
     });
   }
 

diff --git a/...e_way_diff/final_readonly/empty_field_value_placeholder/empty_field_value_placeholder.tsx b/...e_way_diff/final_readonly/empty_field_value_placeholder/empty_field_value_placeholder.tsx
@@ -12,7 +12,7 @@ import * as i18n from './translations';
 export function EmptyFieldValuePlaceholder() {
   return (
     <EuiText size="s" color="subdued">
-      {i18n.EMPTY_FIELD_VALUE_PLACEHOLDER}
+      {`<${i18n.EMPTY_FIELD_VALUE_PLACEHOLDER}>`}
     </EuiText>
   );
 }
diff --git a/.../rule_details/three_way_diff/final_readonly/empty_field_value_placeholder/translations.ts b/.../rule_details/three_way_diff/final_readonly/empty_field_value_placeholder/translations.ts
@@ -10,6 +10,6 @@ import { i18n } from '@kbn/i18n';
 export const EMPTY_FIELD_VALUE_PLACEHOLDER = i18n.translate(
   'xpack.securitySolution.detectionEngine.rules.upgradeRules.emptyFieldValuePlaceholder',
   {
-    defaultMessage: '<Field value is empty>',
+    defaultMessage: 'Field value is empty',
   }
 );