fix bug where convertToSnakeCase would throw error 'cannot convert nu…

…ll or undefined to object' if passed null
elastic · Jan 17, 2020 · 6a91090 · 6a91090
1 parent 6fb3b35
commit 6a91090
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.ts b/...k/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.ts
@@ -68,7 +68,10 @@ export const createFindRulesStatusRoute: Hapi.ServerRoute = {
       return {
         ...(await acc),
         [id]: {
-          current_status: convertToSnakeCase(lastFiveErrorsForId.saved_objects[0].attributes),
+          current_status:
+            lastFiveErrorsForId.saved_objects.length > 0
+              ? convertToSnakeCase(lastFiveErrorsForId.saved_objects[0].attributes)
+              : null,
           failures: lastFiveErrorsForId.saved_objects
             .slice(1)
             .map(errorItem => convertToSnakeCase(errorItem.attributes)),

diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/types.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/types.ts
@@ -58,8 +58,8 @@ export interface IRuleStatusAttributes {
 
 export interface RuleStatusResponse {
   [key: string]: {
-    current_status: IRuleStatusAttributes;
-    failures: IRuleStatusAttributes[];
+    current_status: IRuleStatusAttributes | null | undefined;
+    failures: IRuleStatusAttributes[] | null | undefined;
   };
 }