Skip to content

Commit

Permalink
Merge branch 'master' into skip-viz-reporting-test
Browse files Browse the repository at this point in the history
  • Loading branch information
kibanamachine authored Oct 5, 2021
2 parents 017eefa + ae7a6cf commit 6c0d879
Show file tree
Hide file tree
Showing 749 changed files with 17,345 additions and 11,352 deletions.
2 changes: 1 addition & 1 deletion .buildkite/pipelines/hourly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ steps:
- command: .buildkite/scripts/steps/functional/oss_misc.sh
label: 'OSS Misc Functional Tests'
agents:
queue: ci-group-4d
queue: ci-group-6
depends_on: build
timeout_in_minutes: 120
retry:
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/pipelines/pull_request/base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ steps:
- command: .buildkite/scripts/steps/functional/oss_misc.sh
label: 'OSS Misc Functional Tests'
agents:
queue: ci-group-4d
queue: ci-group-6
depends_on: build
timeout_in_minutes: 120
retry:
Expand Down
4 changes: 2 additions & 2 deletions .buildkite/scripts/common/env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ else
fi

# These are for backwards-compatibility
export GIT_COMMIT="$BUILDKITE_COMMIT"
export GIT_BRANCH="$BUILDKITE_BRANCH"
export GIT_COMMIT="${BUILDKITE_COMMIT:-}"
export GIT_BRANCH="${BUILDKITE_BRANCH:-}"

export FLEET_PACKAGE_REGISTRY_PORT=6104
export TEST_CORS_SERVER_PORT=6105
Expand Down
1 change: 1 addition & 0 deletions .buildkite/scripts/packer_cache.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

set -euo pipefail

source .buildkite/scripts/common/util.sh
source .buildkite/scripts/common/env.sh
source .buildkite/scripts/common/setup_node.sh

Expand Down
3 changes: 0 additions & 3 deletions .buildkite/scripts/steps/functional/oss_misc.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

set -euo pipefail

# Required, at least for kbn_sample_panel_action
export BUILD_TS_REFS_DISABLE=false

source .buildkite/scripts/steps/functional/common.sh

# Required, at least for plugin_functional tests
Expand Down
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
/packages/kbn-interpreter/ @elastic/kibana-app-services
/src/plugins/bfetch/ @elastic/kibana-app-services
/src/plugins/data/ @elastic/kibana-app-services
/src/plugins/data-views/ @elastic/kibana-app-services
/src/plugins/embeddable/ @elastic/kibana-app-services
/src/plugins/expressions/ @elastic/kibana-app-services
/src/plugins/field_formats/ @elastic/kibana-app-services
Expand Down Expand Up @@ -447,4 +448,5 @@
/docs/setup/configuring-reporting.asciidoc @elastic/kibana-reporting-services @elastic/kibana-app-services
#CC# /x-pack/plugins/reporting/ @elastic/kibana-reporting-services


# EUI design
/src/plugins/kibana_react/public/page_template/ @elastic/eui-design @elastic/kibana-app-services
1 change: 1 addition & 0 deletions .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"bfetch": "src/plugins/bfetch",
"dashboard": "src/plugins/dashboard",
"data": "src/plugins/data",
"dataViews": "src/plugins/data_views",
"embeddableApi": "src/plugins/embeddable",
"embeddableExamples": "examples/embeddable_examples",
"fieldFormats": "src/plugins/field_formats",
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Contributing to Kibana

If you are an employee at Elastic, please check out our Developer Guide [here](https://docs.elastic.dev/kibana-dev-docs/welcome).
If you are an employee at Elastic, please check out our Developer Guide [here](https://docs.elastic.dev/kibana-dev-docs/getting-started/welcome).

If you are an external developer, we have a legacy developer guide [here](https://www.elastic.co/guide/en/kibana/master/development.html), or you can view the raw docs from our new, internal Developer Guide [here](./dev_docs/getting_started/dev_welcome.mdx). Eventually, our internal Developer Guide will be opened for public consumption.
2 changes: 1 addition & 1 deletion STYLEGUIDE.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibStyleGuide
slug: /kibana-dev-docs/styleguide
slug: /kibana-dev-docs/contributing/styleguide
title: Style Guide
summary: JavaScript/TypeScript styleguide.
date: 2021-05-06
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/api_welcome.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibDevDocsApiWelcome
slug: /kibana-dev-docs/api-welcome
slug: /kibana-dev-docs/api-meta/welcome
title: Welcome
summary: How to use our automatically generated API documentation
date: 2021-02-25
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibBestPractices
slug: /kibana-dev-docs/best-practices
slug: /kibana-dev-docs/contributing/best-practices
title: Best practices
summary: Best practices to follow when building a Kibana plugin.
date: 2021-03-17
Expand Down Expand Up @@ -111,7 +111,7 @@ export getSearchService: (searchSpec: { username: string; password: string }) =>

In the former, there will be a link to the `SearchSpec` interface with documentation for the `username` and `password` properties. In the latter the object will render inline, without comments:

![prefer interfaces documentation](./assets/dev_docs_nested_object.png)
![prefer interfaces documentation](../assets/dev_docs_nested_object.png)

#### Export every type used in a public API

Expand All @@ -135,7 +135,7 @@ export type foo: string | AnInterface;

`Pick` not only ends up being unhelpful in our documentation system, but it's also of limited help in your IDE. For that reason, avoid `Pick` and other similarly complex types on your public API items. Using these semantics internally is fine.

![pick api documentation](./assets/api_doc_pick.png)
![pick api documentation](../assets/api_doc_pick.png)

### Example plugins

Expand Down Expand Up @@ -210,7 +210,7 @@ your large change right _after_ feature freeze. If you are worried about missing

When possible, build features with incrementals sets of small and focused PRs, but don't check in unused code, and don't expose any feature on master that you would not be comfortable releasing.

![product_stages](./assets/product_stages.png)
![product_stages](../assets/product_stages.png)

If your feature cannot be broken down into smaller components, or multiple engineers will be contributing, you have a few other options to consider.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
id: kibDevPrinciples
slug: /kibana-dev-docs/dev-principles
slug: /kibana-dev-docs/contributing/dev-principles
title: Developer principles
summary: Follow our development principles to help keep our code base stable, maintainable and scalable.
summary: Follow our development principles to help keep our code base stable, maintainable and scalable.
date: 2021-03-04
tags: ['kibana','onboarding', 'dev', 'architecture']
tags: ['kibana', 'onboarding', 'dev', 'architecture']
---

Over time, the Kibana project has been shaped by certain principles. Like Kibana itself, some of these principles were formed by intention while others were the result of evolution and circumstance, but today all are important for the continued success and maintainability of Kibana.
Expand Down Expand Up @@ -117,4 +117,4 @@ The primary consumers of the code we write, the APIs that we create, and the fea

Features that we anticipate end users, admins, and plugin developers consuming should be documented through our official docs, but module-level READMEs and code comments are also appropriate.

Documentation is critical part of developing features and code, so an undocumented feature is an incomplete feature.
Documentation is critical part of developing features and code, so an undocumented feature is an incomplete feature.
2 changes: 1 addition & 1 deletion dev_docs/contributing/how_we_use_github.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibGitHub
slug: /kibana-dev-docs/github
slug: /kibana-dev-docs/contributing/github
title: How we use Github
summary: Forking, branching, committing and using labels in the Kibana GitHub repo
date: 2021-09-16
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/contributing/standards.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ tags: ['contributor', 'dev', 'github', 'getting started', 'onboarding', 'kibana'

## Developer principles

We expect all developers to read and abide by our overarching <DocLink id="kibDeveloperPrinciples" />.
We expect all developers to read and abide by our overarching <DocLink id="kibDevPrinciples" />.

## Style guide

Expand Down
2 changes: 1 addition & 1 deletion dev_docs/getting_started/add_data.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibDevAddData
slug: /kibana-dev-docs/tutorial/sample-data
slug: /kibana-dev-docs/getting-started/sample-data
title: Add data
summary: Learn how to add data to Kibana
date: 2021-08-11
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/getting_started/dev_welcome.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibDevDocsWelcome
slug: /kibana-dev-docs/welcome
slug: /kibana-dev-docs/getting-started/welcome
title: Welcome
summary: Build custom solutions and applications on top of Kibana.
date: 2021-01-02
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/getting_started/hello_world_plugin.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibHelloWorldApp
slug: /kibana-dev-docs/hello-world-app
slug: /kibana-dev-docs/getting-started/hello-world-app
title: Hello World
summary: Build a very basic plugin that registers an application that says "Hello World!".
date: 2021-08-03
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/getting_started/setting_up_a_development_env.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibDevTutorialSetupDevEnv
slug: /kibana-dev-docs/tutorial/setup-dev-env
slug: /kibana-dev-docs/getting-started/setup-dev-env
title: Set up a Development Environment
summary: Learn how to setup a development environment for contributing to the Kibana repository
date: 2021-04-26
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibTroubleshooting
slug: /kibana-dev-docs/troubleshooting
slug: /kibana-dev-docs/getting-started/troubleshooting
title: Troubleshooting
summary: A collection of tips for working around strange issues.
date: 2021-09-08
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/key_concepts/anatomy_of_a_plugin.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
id: kibDevAnatomyOfAPlugin
slug: /kibana-dev-docs/anatomy-of-a-plugin
slug: /kibana-dev-docs/key-concepts/anatomy-of-a-plugin
title: Anatomy of a plugin
summary: Anatomy of a Kibana plugin.
date: 2021-08-03
Expand Down
Loading

0 comments on commit 6c0d879

Please sign in to comment.