Merge branch 'master' into improve-rule-actions

.eslintignore

@@ -41,7 +41,5 @@ snapshots.js
 /packages/kbn-test/src/functional_test_runner/__tests__/fixtures/
 /packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
 /packages/kbn-ui-framework/dist
-/packages/kbn-ui-framework/doc_site/build
-/packages/kbn-ui-framework/generator-kui/*/templates/
 /packages/kbn-ui-shared-deps/flot_charts
 /packages/kbn-monaco/src/painless/antlr

.eslintrc.js

@@ -85,12 +85,6 @@ module.exports = {
     /**
      * Temporarily disable some react rules for specific plugins, remove in separate PRs
      */
-    {
-      files: ['packages/kbn-ui-framework/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'jsx-a11y/no-onchange': 'off',
-      },
-    },
     {
       files: ['src/plugins/kibana_react/**/*.{js,mjs,ts,tsx}'],
       rules: {
@@ -413,7 +407,6 @@ module.exports = {
     {
       files: [
         '**/public/**/*.js',
-        'packages/kbn-ui-framework/doc_site/src/**/*.js',
         'src/fixtures/**/*.js', // TODO: this directory needs to be more obviously "public" (or go away)
       ],
       settings: {
@@ -436,11 +429,7 @@ module.exports = {
      * Files that ARE NOT allowed to use devDependencies
      */
     {
-      files: [
-        'packages/kbn-ui-framework/**/*.js',
-        'x-pack/**/*.js',
-        'packages/kbn-interpreter/**/*.js',
-      ],
+      files: ['x-pack/**/*.js', 'packages/kbn-interpreter/**/*.js'],
       rules: {
         'import/no-extraneous-dependencies': [
           'error',
@@ -458,10 +447,6 @@ module.exports = {
      */
     {
       files: [
-        'packages/kbn-ui-framework/**/*.test.js',
-        'packages/kbn-ui-framework/doc_site/**/*.js',
-        'packages/kbn-ui-framework/generator-kui/**/*.js',
-        'packages/kbn-ui-framework/Gruntfile.js',
         'packages/kbn-es/src/**/*.js',
         'packages/kbn-interpreter/tasks/**/*.js',
         'packages/kbn-interpreter/src/plugin/**/*.js',
@@ -1073,20 +1058,6 @@ module.exports = {
       },
     },
 
-    /**
-     * disable jsx-a11y for kbn-ui-framework
-     */
-    {
-      files: ['packages/kbn-ui-framework/**/*.js'],
-      rules: {
-        'jsx-a11y/click-events-have-key-events': 'off',
-        'jsx-a11y/anchor-has-content': 'off',
-        'jsx-a11y/tabindex-no-positive': 'off',
-        'jsx-a11y/label-has-associated-control': 'off',
-        'jsx-a11y/aria-role': 'off',
-      },
-    },
-
     /**
      * Canvas overrides
      */

.gitignore

@@ -49,8 +49,6 @@ selenium
 *.swp
 *.swo
 *.out
-/packages/kbn-ui-framework/doc_site/build/*
-!/packages/kbn-ui-framework/doc_site/build/index.html
 package-lock.json
 .yo-rc.json
 .vscode

SECURITY.md

@@ -0,0 +1,7 @@
+# Security Policy
+
+Thanks for your interest in the security of our products.
+Our security policy can be found at [https://www.elastic.co/community/security](https://www.elastic.co/community/security).
+
+## Reporting a Vulnerability
+Please send security vulnerability reports to security@elastic.co.

docs/development/core/public/kibana-plugin-core-public.appleaveconfirmaction.callback.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [AppLeaveConfirmAction](./kibana-plugin-core-public.appleaveconfirmaction.md) &gt; [callback](./kibana-plugin-core-public.appleaveconfirmaction.callback.md)
+
+## AppLeaveConfirmAction.callback property
+
+<b>Signature:</b>
+
+```typescript
+callback?: () => void;
+```

docs/development/core/public/kibana-plugin-core-public.appleaveconfirmaction.md

@@ -18,6 +18,7 @@ export interface AppLeaveConfirmAction
 
 |  Property | Type | Description |
 |  --- | --- | --- |
+|  [callback](./kibana-plugin-core-public.appleaveconfirmaction.callback.md) | <code>() =&gt; void</code> |  |
 |  [text](./kibana-plugin-core-public.appleaveconfirmaction.text.md) | <code>string</code> |  |
 |  [title](./kibana-plugin-core-public.appleaveconfirmaction.title.md) | <code>string</code> |  |
 |  [type](./kibana-plugin-core-public.appleaveconfirmaction.type.md) | <code>AppLeaveActionType.confirm</code> |  |

docs/development/core/public/kibana-plugin-core-public.appleavehandler.md

@@ -11,5 +11,5 @@ See [AppMountParameters](./kibana-plugin-core-public.appmountparameters.md) for
 <b>Signature:</b>
 
 ```typescript
-export declare type AppLeaveHandler = (factory: AppLeaveActionFactory) => AppLeaveAction;
+export declare type AppLeaveHandler = (factory: AppLeaveActionFactory, nextAppId?: string) => AppLeaveAction;
 ```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionlinkbase.md

@@ -0,0 +1,12 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionLinkBase](./kibana-plugin-core-public.chromehelpextensionlinkbase.md)
+
+## ChromeHelpExtensionLinkBase type
+
+
+<b>Signature:</b>
+
+```typescript
+export declare type ChromeHelpExtensionLinkBase = Pick<EuiButtonEmptyProps, 'iconType' | 'target' | 'rel' | 'data-test-subj'>;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenucustomlink.content.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuCustomLink](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.md) &gt; [content](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.content.md)
+
+## ChromeHelpExtensionMenuCustomLink.content property
+
+Content of the button (in lieu of `children`<!-- -->)
+
+<b>Signature:</b>
+
+```typescript
+content: React.ReactNode;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenucustomlink.href.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuCustomLink](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.md) &gt; [href](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.href.md)
+
+## ChromeHelpExtensionMenuCustomLink.href property
+
+URL of the link
+
+<b>Signature:</b>
+
+```typescript
+href: string;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenucustomlink.linktype.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuCustomLink](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.md) &gt; [linkType](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.linktype.md)
+
+## ChromeHelpExtensionMenuCustomLink.linkType property
+
+Extend EuiButtonEmpty to provide extra functionality
+
+<b>Signature:</b>
+
+```typescript
+linkType: 'custom';
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenucustomlink.md

@@ -2,14 +2,20 @@
 
 [Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [ChromeHelpExtensionMenuCustomLink](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.md)
 
-## ChromeHelpExtensionMenuCustomLink type
+## ChromeHelpExtensionMenuCustomLink interface
 
 
 <b>Signature:</b>
 
 ```typescript
-export declare type ChromeHelpExtensionMenuCustomLink = EuiButtonEmptyProps & {
-    linkType: 'custom';
-    content: React.ReactNode;
-};
+export interface ChromeHelpExtensionMenuCustomLink extends ChromeHelpExtensionLinkBase 
 ```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [content](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.content.md) | <code>React.ReactNode</code> | Content of the button (in lieu of <code>children</code>) |
+|  [href](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.href.md) | <code>string</code> | URL of the link |
+|  [linkType](./kibana-plugin-core-public.chromehelpextensionmenucustomlink.linktype.md) | <code>'custom'</code> | Extend EuiButtonEmpty to provide extra functionality |
+

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudiscusslink.href.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuDiscussLink](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.md) &gt; [href](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.href.md)
+
+## ChromeHelpExtensionMenuDiscussLink.href property
+
+URL to discuss page. i.e. `https://discuss.elastic.co/c/${appName}`
+
+<b>Signature:</b>
+
+```typescript
+href: string;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudiscusslink.linktype.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuDiscussLink](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.md) &gt; [linkType](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.linktype.md)
+
+## ChromeHelpExtensionMenuDiscussLink.linkType property
+
+Creates a generic give feedback link with comment icon
+
+<b>Signature:</b>
+
+```typescript
+linkType: 'discuss';
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudiscusslink.md

@@ -2,14 +2,19 @@
 
 [Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [ChromeHelpExtensionMenuDiscussLink](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.md)
 
-## ChromeHelpExtensionMenuDiscussLink type
+## ChromeHelpExtensionMenuDiscussLink interface
 
 
 <b>Signature:</b>
 
 ```typescript
-export declare type ChromeHelpExtensionMenuDiscussLink = EuiButtonEmptyProps & {
-    linkType: 'discuss';
-    href: string;
-};
+export interface ChromeHelpExtensionMenuDiscussLink extends ChromeHelpExtensionLinkBase 
 ```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [href](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.href.md) | <code>string</code> | URL to discuss page. i.e. <code>https://discuss.elastic.co/c/${appName}</code> |
+|  [linkType](./kibana-plugin-core-public.chromehelpextensionmenudiscusslink.linktype.md) | <code>'discuss'</code> | Creates a generic give feedback link with comment icon |
+

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.href.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuDocumentationLink](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.md) &gt; [href](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.href.md)
+
+## ChromeHelpExtensionMenuDocumentationLink.href property
+
+URL to documentation page. i.e. `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/${appName}.html`<!-- -->,
+
+<b>Signature:</b>
+
+```typescript
+href: string;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.linktype.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuDocumentationLink](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.md) &gt; [linkType](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.linktype.md)
+
+## ChromeHelpExtensionMenuDocumentationLink.linkType property
+
+Creates a deep-link to app-specific documentation
+
+<b>Signature:</b>
+
+```typescript
+linkType: 'documentation';
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.md

@@ -2,14 +2,19 @@
 
 [Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [ChromeHelpExtensionMenuDocumentationLink](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.md)
 
-## ChromeHelpExtensionMenuDocumentationLink type
+## ChromeHelpExtensionMenuDocumentationLink interface
 
 
 <b>Signature:</b>
 
 ```typescript
-export declare type ChromeHelpExtensionMenuDocumentationLink = EuiButtonEmptyProps & {
-    linkType: 'documentation';
-    href: string;
-};
+export interface ChromeHelpExtensionMenuDocumentationLink extends ChromeHelpExtensionLinkBase 
 ```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [href](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.href.md) | <code>string</code> | URL to documentation page. i.e. <code>${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/${appName}.html</code>, |
+|  [linkType](./kibana-plugin-core-public.chromehelpextensionmenudocumentationlink.linktype.md) | <code>'documentation'</code> | Creates a deep-link to app-specific documentation |
+

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenugithublink.labels.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuGitHubLink](./kibana-plugin-core-public.chromehelpextensionmenugithublink.md) &gt; [labels](./kibana-plugin-core-public.chromehelpextensionmenugithublink.labels.md)
+
+## ChromeHelpExtensionMenuGitHubLink.labels property
+
+Include at least one app-specific label to be applied to the new github issue
+
+<b>Signature:</b>
+
+```typescript
+labels: string[];
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenugithublink.linktype.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuGitHubLink](./kibana-plugin-core-public.chromehelpextensionmenugithublink.md) &gt; [linkType](./kibana-plugin-core-public.chromehelpextensionmenugithublink.linktype.md)
+
+## ChromeHelpExtensionMenuGitHubLink.linkType property
+
+Creates a link to a new github issue in the Kibana repo
+
+<b>Signature:</b>
+
+```typescript
+linkType: 'github';
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenugithublink.md

@@ -2,15 +2,20 @@
 
 [Home](./index.md) > [kibana-plugin-core-public](./kibana-plugin-core-public.md) > [ChromeHelpExtensionMenuGitHubLink](./kibana-plugin-core-public.chromehelpextensionmenugithublink.md)
 
-## ChromeHelpExtensionMenuGitHubLink type
+## ChromeHelpExtensionMenuGitHubLink interface
 
 
 <b>Signature:</b>
 
 ```typescript
-export declare type ChromeHelpExtensionMenuGitHubLink = EuiButtonEmptyProps & {
-    linkType: 'github';
-    labels: string[];
-    title?: string;
-};
+export interface ChromeHelpExtensionMenuGitHubLink extends ChromeHelpExtensionLinkBase 
 ```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [labels](./kibana-plugin-core-public.chromehelpextensionmenugithublink.labels.md) | <code>string[]</code> | Include at least one app-specific label to be applied to the new github issue |
+|  [linkType](./kibana-plugin-core-public.chromehelpextensionmenugithublink.linktype.md) | <code>'github'</code> | Creates a link to a new github issue in the Kibana repo |
+|  [title](./kibana-plugin-core-public.chromehelpextensionmenugithublink.title.md) | <code>string</code> | Provides initial text for the title of the issue |
+

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenugithublink.title.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeHelpExtensionMenuGitHubLink](./kibana-plugin-core-public.chromehelpextensionmenugithublink.md) &gt; [title](./kibana-plugin-core-public.chromehelpextensionmenugithublink.title.md)
+
+## ChromeHelpExtensionMenuGitHubLink.title property
+
+Provides initial text for the title of the issue
+
+<b>Signature:</b>
+
+```typescript
+title?: string;
+```

docs/development/core/public/kibana-plugin-core-public.chromehelpextensionmenulink.md

@@ -8,5 +8,5 @@
 <b>Signature:</b>
 
 ```typescript
-export declare type ChromeHelpExtensionMenuLink = ExclusiveUnion<ChromeHelpExtensionMenuGitHubLink, ExclusiveUnion<ChromeHelpExtensionMenuDiscussLink, ExclusiveUnion<ChromeHelpExtensionMenuDocumentationLink, ChromeHelpExtensionMenuCustomLink>>>;
+export declare type ChromeHelpExtensionMenuLink = ChromeHelpExtensionMenuGitHubLink | ChromeHelpExtensionMenuDiscussLink | ChromeHelpExtensionMenuDocumentationLink | ChromeHelpExtensionMenuCustomLink;
 ```

docs/development/core/public/kibana-plugin-core-public.iexternalurlpolicy.host.md

@@ -4,7 +4,7 @@
 
 ## IExternalUrlPolicy.host property
 
-Optional host describing the external destination. May be combined with `protocol`<!-- -->. Required if `protocol` is not defined.
+Optional host describing the external destination. May be combined with `protocol`<!-- -->.
 
 <b>Signature:</b>
 

docs/development/core/public/kibana-plugin-core-public.iexternalurlpolicy.md

@@ -17,6 +17,6 @@ export interface IExternalUrlPolicy
 |  Property | Type | Description |
 |  --- | --- | --- |
 |  [allow](./kibana-plugin-core-public.iexternalurlpolicy.allow.md) | <code>boolean</code> | Indicates if this policy allows or denies access to the described destination. |
-|  [host](./kibana-plugin-core-public.iexternalurlpolicy.host.md) | <code>string</code> | Optional host describing the external destination. May be combined with <code>protocol</code>. Required if <code>protocol</code> is not defined. |
-|  [protocol](./kibana-plugin-core-public.iexternalurlpolicy.protocol.md) | <code>string</code> | Optional protocol describing the external destination. May be combined with <code>host</code>. Required if <code>host</code> is not defined. |
+|  [host](./kibana-plugin-core-public.iexternalurlpolicy.host.md) | <code>string</code> | Optional host describing the external destination. May be combined with <code>protocol</code>. |
+|  [protocol](./kibana-plugin-core-public.iexternalurlpolicy.protocol.md) | <code>string</code> | Optional protocol describing the external destination. May be combined with <code>host</code>. |