[Advanced settings] Reset to default for empty strings (#85137) (#85516)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · Dec 10, 2020 · 71990e2 · 71990e2
1 parent f5ae464
commit 71990e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/plugins/advanced_settings/public/management_app/lib/is_default_value.test.ts b/src/plugins/advanced_settings/public/management_app/lib/is_default_value.test.ts
@@ -50,9 +50,9 @@ describe('Settings', function () {
         });
 
         describe('without a value', function () {
-          it('should return true', function () {
+          it('should return false for empty string but true for undefined', function () {
             expect(isDefaultValue({ ...setting, value: undefined })).to.be(true);
-            expect(isDefaultValue({ ...setting, value: '' })).to.be(true);
+            expect(isDefaultValue({ ...setting, value: '' })).to.be(false);
           });
         });
 

diff --git a/src/plugins/advanced_settings/public/management_app/lib/is_default_value.ts b/src/plugins/advanced_settings/public/management_app/lib/is_default_value.ts
@@ -22,7 +22,6 @@ export function isDefaultValue(setting: FieldSetting) {
   return (
     setting.isCustom ||
     setting.value === undefined ||
-    setting.value === '' ||
     String(setting.value) === String(setting.defVal)
   );
 }