Merge branch 'master' of github.com:elastic/kibana into feature/unlin…

…kFromLibraryActionWithInterface

.sass-lint.yml

@@ -1,6 +1,7 @@
 files:
   include:
     - 'src/legacy/core_plugins/metrics/**/*.s+(a|c)ss'
+    - 'src/plugins/index_pattern_management/**/*.s+(a|c)ss'
     - 'src/plugins/timelion/**/*.s+(a|c)ss'
     - 'src/plugins/vis_type_vislib/**/*.s+(a|c)ss'
     - 'src/plugins/vis_type_vega/**/*.s+(a|c)ss'

docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md

@@ -81,6 +81,7 @@ readonly links: {
             readonly loadingData: string;
             readonly introduction: string;
         };
+        readonly addData: string;
         readonly kibana: string;
         readonly siem: {
             readonly guide: string;

docs/setup/connect-to-elasticsearch.asciidoc

@@ -97,7 +97,7 @@ Using a wildcard is the more popular approach.
 comparisons.
 +
 Kibana reads the index mapping and lists all fields that contain a timestamp. If your
-index doesn't have time-based data, choose *I don't want to use the Time Filter*.
+index doesn't have time-based data, choose *I don't want to use the time filter*.
 +
 You must select a time field to use global time filters on your dashboards.
 

packages/kbn-pm/dist/index.js

@@ -15108,7 +15108,7 @@ function getMarkerLines(loc, source, opts) {
     column: 0,
     line: -1
   }, loc.start);
-  const endLoc = Object.assign({}, startLoc, {}, loc.end);
+  const endLoc = Object.assign({}, startLoc, loc.end);
   const {
     linesAbove = 2,
     linesBelow = 3
@@ -15530,7 +15530,7 @@ function isIdentifierName(name) {
     }
   }
 
-  return true;
+  return !isFirst;
 }
 
 /***/ }),

src/core/public/doc_links/doc_links_service.ts

@@ -109,6 +109,7 @@ export class DocLinksService {
           loadingData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/tutorial-load-dataset.html`,
           introduction: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index-patterns.html`,
         },
+        addData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/connect-to-elasticsearch.html`,
         kibana: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index.html`,
         siem: {
           guide: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`,
@@ -209,6 +210,7 @@ export interface DocLinksStart {
       readonly loadingData: string;
       readonly introduction: string;
     };
+    readonly addData: string;
     readonly kibana: string;
     readonly siem: {
       readonly guide: string;

src/core/public/public.api.md

@@ -576,6 +576,7 @@ export interface DocLinksStart {
             readonly loadingData: string;
             readonly introduction: string;
         };
+        readonly addData: string;
         readonly kibana: string;
         readonly siem: {
             readonly guide: string;

src/dev/build/lib/__mocks__/get_build_number.ts

@@ -0,0 +1,22 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export function getBuildNumber() {
+  return 12345;
+}

src/dev/build/lib/get_build_number.ts

@@ -0,0 +1,34 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import os from 'os';
+import execa from 'execa';
+
+export async function getBuildNumber() {
+  if (/^win/.test(os.platform())) {
+    // Windows does not have the wc process and `find /C /V ""` does not consistently work
+    const log = await execa('git', ['log', '--format="%h"']);
+    return log.stdout.split('\n').length;
+  }
+
+  const wc = await execa.command('git log --format="%h" | wc -l', {
+    shell: true,
+  });
+  return parseFloat(wc.stdout.trim());
+}

src/dev/build/lib/version_info.test.ts

@@ -20,6 +20,8 @@
 import pkg from '../../../../package.json';
 import { getVersionInfo } from './version_info';
 
+jest.mock('./get_build_number');
+
 describe('isRelease = true', () => {
   it('returns unchanged package.version, build sha, and build number', async () => {
     const versionInfo = await getVersionInfo({

src/dev/build/lib/version_info.ts

@@ -17,22 +17,8 @@
  * under the License.
  */
 
-import os from 'os';
-
 import execa from 'execa';
-
-async function getBuildNumber() {
-  if (/^win/.test(os.platform())) {
-    // Windows does not have the wc process and `find /C /V ""` does not consistently work
-    const log = await execa('git', ['log', '--format="%h"']);
-    return log.stdout.split('\n').length;
-  }
-
-  const wc = await execa.command('git log --format="%h" | wc -l', {
-    shell: true,
-  });
-  return parseFloat(wc.stdout.trim());
-}
+import { getBuildNumber } from './get_build_number';
 
 interface Options {
   isRelease: boolean;

src/dev/build/tasks/nodejs/download_node_builds_task.test.ts

@@ -26,13 +26,10 @@ import {
 import { Config, Platform } from '../../lib';
 import { DownloadNodeBuilds } from './download_node_builds_task';
 
-// import * as NodeShasumsNS from '../node_shasums';
-// import * as NodeDownloadInfoNS from '../node_download_info';
-// import * as DownloadNS from '../../../lib/download';
-// import { DownloadNodeBuilds } from '../download_node_builds_task';
 jest.mock('./node_shasums');
 jest.mock('./node_download_info');
 jest.mock('../../lib/download');
+jest.mock('../../lib/get_build_number');
 
 expect.addSnapshotSerializer(createAnyInstanceSerializer(ToolingLog));
 

src/dev/build/tasks/nodejs/extract_node_builds_task.test.ts

@@ -27,6 +27,7 @@ import { Config } from '../../lib';
 import { ExtractNodeBuilds } from './extract_node_builds_task';
 
 jest.mock('../../lib/fs');
+jest.mock('../../lib/get_build_number');
 
 const Fs = jest.requireMock('../../lib/fs');
 

src/dev/build/tasks/nodejs/verify_existing_node_builds_task.test.ts

@@ -29,6 +29,7 @@ import { VerifyExistingNodeBuilds } from './verify_existing_node_builds_task';
 jest.mock('./node_shasums');
 jest.mock('./node_download_info');
 jest.mock('../../lib/fs');
+jest.mock('../../lib/get_build_number');
 
 const { getNodeShasums } = jest.requireMock('./node_shasums');
 const { getNodeDownloadInfo } = jest.requireMock('./node_download_info');

src/plugins/data/public/index_patterns/index_patterns/redirect_no_index_pattern.tsx

@@ -40,7 +40,7 @@ export const onRedirectNoIndexPattern = (
 
   const bannerMessage = i18n.translate('data.indexPatterns.ensureDefaultIndexPattern.bannerLabel', {
     defaultMessage:
-      "In order to visualize and explore data in Kibana, you'll need to create an index pattern to retrieve data from Elasticsearch.",
+      'To visualize and explore data in Kibana, you must create an index pattern to retrieve data from Elasticsearch.',
   });
 
   // Avoid being hostile to new users who don't have an index pattern setup yet

src/plugins/index_pattern_management/public/_templates.scss

@@ -0,0 +1,11 @@
+%inp-empty-state-footer {
+  background: $euiColorLightestShade;
+  margin: 0 (-$euiSizeL) (-$euiSizeL);
+  padding: $euiSizeL;
+  border-radius: 0 0 $euiBorderRadius $euiBorderRadius;
+
+  // sass-lint:disable-block mixins-before-declarations
+  @include euiBreakpoint('xs', 's') {
+    text-align: center;
+  }
+}

src/plugins/index_pattern_management/public/_variables.scss

@@ -0,0 +1 @@
+$inpEmptyStateMaxWidth: $euiSizeXXL * 19;