Removed popover directive (#33437)

* Deleted popover directive from angular-bootstrap Copied a part of popover to ml angular bootstrap patch Deleted unused dropdown directives from ml angular bootstrap patch * Removed unused dropdown css
elastic · Mar 19, 2019 · 7c0a776 · 7c0a776
1 parent 6e02912
commit 7c0a776
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 364 deletions.
diff --git a/src/legacy/ui/public/angular-bootstrap/index.js b/src/legacy/ui/public/angular-bootstrap/index.js
@@ -31,7 +31,6 @@ angular.module('ui.bootstrap', [
   'ui.bootstrap.modal',
   'ui.bootstrap.pagination',
   'ui.bootstrap.tooltip',
-  'ui.bootstrap.popover',
   'ui.bootstrap.progressbar',
   'ui.bootstrap.tabs',
   'ui.bootstrap.timepicker',
@@ -46,7 +45,6 @@ angular.module('ui.bootstrap.tpls', [
   'template/pagination/pagination.html',
   'template/tooltip/tooltip-html-unsafe-popup.html',
   'template/tooltip/tooltip-popup.html',
-  'template/popover/popover.html',
   'template/progressbar/bar.html',
   'template/progressbar/progress.html',
   'template/progressbar/progressbar.html',
@@ -63,7 +61,6 @@ import './buttons/buttons';
 import './dropdown/dropdown';
 import './modal/modal';
 import './pagination/pagination';
-import './popover/popover';
 import './position/position';
 import './progressbar/progressbar';
 import './tabs/tabs';
@@ -114,12 +111,6 @@ angular.module('template/tooltip/tooltip-popup.html', []).run(['$templateCache',
   $templateCache.put('template/tooltip/tooltip-popup.html', tooltipPopup);
 }]);
 
-import popover from './popover/popover.html';
-
-angular.module('template/popover/popover.html', []).run(['$templateCache', function($templateCache) {
-  $templateCache.put('template/popover/popover.html', popover);
-}]);
-
 import bar from './progressbar/bar.html';
 
 angular.module('template/progressbar/bar.html', []).run(['$templateCache', function($templateCache) {

diff --git a/src/legacy/ui/public/angular-bootstrap/popover/popover.html b/src/legacy/ui/public/angular-bootstrap/popover/popover.html
diff --git a/src/legacy/ui/public/angular-bootstrap/popover/popover.js b/src/legacy/ui/public/angular-bootstrap/popover/popover.js
diff --git a/x-pack/plugins/ml/public/explorer/_explorer.scss b/x-pack/plugins/ml/public/explorer/_explorer.scss
@@ -87,45 +87,6 @@
       position: relative;
       display: inline-block;
     }
-
-    button.dropdown-toggle {
-      // SASSTODO: Make a proper calc
-      min-width: 160px;
-      text-align: left;
-      margin-bottom: $euiSizeXS;
-
-      // SASSTODO: Make a proper selector
-      span {
-        font-size: $euiFontSizeXS;
-      }
-    }
-
-    // SASSTODO: Make a proper calc
-    button.dropdown-toggle.dropdown-toggle-narrow {
-      min-width: 60px;
-    }
-
-    button.dropdown-toggle:hover,
-    button.dropdown-toggle:focus {
-      color: $euiColorDarkShade;
-    }
-
-    .dropdown-menu {
-      font-size: $euiFontSizeXS;
-    }
-
-      // SASSTODO: Make a proper selector
-    .dropdown-menu > li > a {
-      color: $euiColorDarkShade;
-      text-decoration: none;
-    }
-
-    .dropdown-menu > li > a:hover,
-    .dropdown-menu > li > a:active,
-    .dropdown-menu > li > a:focus {
-      color: $euiColorEmptyShade;
-      box-shadow: none;
-    }
   }
 
   .ml-anomalies-controls {

diff --git a/x-pack/plugins/ml/public/explorer/explorer_charts/_explorer_charts_container.scss b/x-pack/plugins/ml/public/explorer/explorer_charts/_explorer_charts_container.scss
@@ -27,44 +27,6 @@
       padding-top: 10px;
     }
 
-    .kuiButton.dropdown-toggle,
-    .open > .dropdown-toggle.kuiButton--primary:hover,
-    .open > .dropdown-toggle.kuiButton--primary:focus {
-      background: transparent;
-      border: none;
-      color: #444444;
-      padding: 0px 50px 0px 0px;
-    }
-
-    .dropdown-menu {
-      min-width: 120px;
-      font-size: 13px;
-    }
-
-    .dropdown-menu > li > a {
-      color: $euiTextColor;
-      text-decoration: none;
-    }
-
-    .dropdown-menu > li > a:hover, .dropdown-menu > li > a:active {
-      color: $euiColorEmptyShade;
-    }
-
-    button.dropdown-toggle {
-      width: 110px;
-      text-align: left;
-      margin-bottom: 3px;
-
-      span {
-        font-size: $euiFontSizeS;
-      }
-    }
-
-    button.dropdown-toggle:hover,
-    button.dropdown-toggle:focus {
-      color: $euiTextColor;
-    }
-
     .ml-anomaly-interim-result {
       font-style: italic;
       padding-bottom: 3px;

diff --git a/x-pack/plugins/ml/public/jobs/new_job/simple/components/watcher/_watcher.scss b/x-pack/plugins/ml/public/jobs/new_job/simple/components/watcher/_watcher.scss
@@ -41,6 +41,7 @@
   .dropdown-toggle {
     cursor: pointer;
   }
+
   button.dropdown-toggle {
     width: 170px; // SASSTODO: Proper calc
     text-align: left;
@@ -52,23 +53,6 @@
     }
   }
 
-  .dropdown-menu {
-    min-width: 120px; // SASSTODO: Proper calc
-    font-size: $euiFontSizeXS;
-
-    // SASSTODO: Proper selector
-    li > a {
-      color: $euiColorDarkShade;
-      text-decoration: none;
-      box-shadow: none;
-    }
-
-    // SASSTODO: Proper selector
-    li > a:hover, li > a:active, li > a:focus {
-      color: $euiColorEmptyShade;
-    }
-  }
-
   .watch-exists-warning {
     color: $euiColorWarning;
   }