Skip to content

Commit

Permalink
Remove last mentions of spy panels (#23527)
Browse files Browse the repository at this point in the history
  • Loading branch information
timroes authored Sep 26, 2018
1 parent 143e7d8 commit 832b896
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docs/setup/settings.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ you'll need to update your `kibana.yml` file. You can also enable SSL and set a
`elasticsearch.customHeaders:`:: *Default: `{}`* Header names and values to send to Elasticsearch. Any custom headers
cannot be overwritten by client-side headers, regardless of the `elasticsearch.requestHeadersWhitelist` configuration.

`elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have a spy panel, for example Timelion and Monitoring.
`elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have an inspector, for example Timelion and Monitoring.

`elasticsearch.pingTimeout:`:: *Default: the value of the `elasticsearch.requestTimeout` setting* Time in milliseconds to
wait for Elasticsearch to respond to pings.
Expand Down
2 changes: 1 addition & 1 deletion src/ui/public/inspector/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

/**
* The interface that the adapters used to open spy panels have to fullfill.
* The interface that the adapters used to open an inspector have to fullfill.
*/
export interface Adapters {
[key: string]: any;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/public/vis/request_handlers/courier.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const CourierRequestHandlerProvider = function () {
aggs.setTimeRange(timeRange);

// For now we need to mirror the history of the passed search source, since
// the spy panel wouldn't work otherwise.
// the request inspector wouldn't work otherwise.
Object.defineProperty(requestSearchSource, 'history', {
get() {
return searchSource.history;
Expand Down
6 changes: 0 additions & 6 deletions src/ui/public/visualize/loader/__tests__/visualize_loader.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,6 @@ describe('visualize loader', () => {
expect(vis.attr('data-foo')).to.be('');
expect(vis.attr('data-with-dash')).to.be('value');
});

it('should hide spy panel control by default', () => {
const vis = embedWithParams({});
expect(vis.find('[data-test-subj="spyToggleButton"]').length).to.be(0);
});

});

describe('embedVisualizationWithId', () => {
Expand Down
2 changes: 0 additions & 2 deletions test/functional/apps/visualize/_tile_map.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export default function ({ getService, getPageObjects }) {


before(async function () {
// Make sure the window is height enough to show the spy panel without hiding the map
remote.setWindowSize(1280, 1000);

const fromTime = '2015-09-19 06:31:44.000';
Expand Down Expand Up @@ -64,7 +63,6 @@ export default function ({ getService, getPageObjects }) {

describe('complete config', function describeIndexTests() {
before(async function () {
// Make sure the window is height enough to show the spy panel without hiding the map
remote.setWindowSize(1280, 1000);

const fromTime = '2015-09-19 06:31:44.000';
Expand Down

0 comments on commit 832b896

Please sign in to comment.