Add comments

elastic · Apr 13, 2023 · 8d04581 · 8d04581
1 parent 387ce0b
commit 8d04581
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts b/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
@@ -852,6 +852,12 @@ export class AlertsClient {
   }
 
   public async removeCaseIdFromAlerts({ caseId, alerts }: RemoveCaseIdFromAlertsOptions) {
+    /**
+     * We intentionally do not perform any authorization
+     * on the alerts. Users should be able to remove
+     * cases from alerts when deleting a case or an
+     * attachment
+     */
     try {
       if (alerts.length === 0) {
         return;
@@ -891,6 +897,12 @@ export class AlertsClient {
   }
 
   public async removeCaseIdsFromAllAlerts({ caseIds }: { caseIds: string[] }) {
+    /**
+     * We intentionally do not perform any authorization
+     * on the alerts. Users should be able to remove
+     * cases from alerts when deleting a case or an
+     * attachment
+     */
     try {
       if (caseIds.length === 0) {
         return;

diff --git a/x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/delete_cases.ts b/x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/delete_cases.ts
@@ -301,11 +301,6 @@ export default ({ getService }: FtrProviderContext): void => {
         });
 
         it('should delete case ID from the alert schema when the user does NOT have access to the alert', async () => {
-          /**
-           * The alerts client throws an expectation failed error (471) when
-           * the user is unauthorized to find alerts for any rule types
-           */
-
           await createCaseAttachAlertAndDeleteCase({
             supertest: supertestWithoutAuth,
             totalCases: 1,