[ftr] unskip serverless functional tests (#167497)

I hope the change made in #166936 allow us to unskip these tests closes #165763 closes #165386 closes #165414 closes #166448 closes #165943 closes #166461 closes #166551 Flaky-test-runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3242 Quick stability check of re-enabled tests: - x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts 100/100 failures - x-pack/test_serverless/functional/test_suites/common/home_page.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/index_management/create_enrich_policy.ts 99/100 - x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts 49/50 - x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts 49/50
elastic · Sep 29, 2023 · 97c7d7d · 97c7d7d
1 parent b888ecb
commit 97c7d7d
Show file tree

Hide file tree

Showing 8 changed files with 47 additions and 23 deletions.
diff --git a/...verless/functional/test_suites/common/examples/search_examples/partial_results_example.ts b/...verless/functional/test_suites/common/examples/search_examples/partial_results_example.ts
@@ -10,16 +10,20 @@ import type { FtrProviderContext } from '../../../../ftr_provider_context';
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const testSubjects = getService('testSubjects');
-  const PageObjects = getPageObjects(['common']);
+  const PageObjects = getPageObjects(['common', 'svlCommonPage']);
   const retry = getService('retry');
 
-  // FLAKY: https://github.com/elastic/kibana/issues/165763
-  describe.skip('Partial results example', () => {
+  describe('Partial results example', () => {
     before(async () => {
+      await PageObjects.svlCommonPage.login();
       await PageObjects.common.navigateToApp('searchExamples');
       await testSubjects.click('/search');
     });
 
+    after(async () => {
+      await PageObjects.svlCommonPage.forceLogout();
+    });
+
     it('should update a progress bar', async () => {
       await testSubjects.click('responseTab');
       const progressBar = await testSubjects.find('progressBar');

diff --git a/...ess/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts b/...ess/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts
@@ -28,7 +28,13 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
   const retry = getService('retry');
   const testSubjects = getService('testSubjects');
   const monacoEditor = getService('monacoEditor');
-  const PageObjects = getPageObjects(['common', 'timePicker', 'header', 'unifiedFieldList']);
+  const PageObjects = getPageObjects([
+    'common',
+    'timePicker',
+    'header',
+    'unifiedFieldList',
+    'svlCommonPage',
+  ]);
   const dataViewTitle = 'existence_index_*';
 
   async function addDSLFilter(value: string) {
@@ -51,16 +57,15 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
     await PageObjects.header.waitUntilLoadingHasFinished();
   }
 
-  // Failing: See https://github.com/elastic/kibana/issues/165938
-  // Failing: See https://github.com/elastic/kibana/issues/165927
-  describe.skip('Fields existence info', () => {
+  describe('Fields existence info', () => {
     before(async () => {
       await esArchiver.load(
         'test/api_integration/fixtures/es_archiver/index_patterns/constant_keyword'
       );
       await kibanaServer.importExport.load(
         'test/api_integration/fixtures/kbn_archiver/index_patterns/constant_keyword.json'
       );
+      await PageObjects.svlCommonPage.login();
       await PageObjects.common.navigateToApp('unifiedFieldListExamples');
       await PageObjects.header.waitUntilLoadingHasFinished();
       await retry.waitFor('combobox is ready', async () => {
@@ -85,6 +90,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
       );
       await PageObjects.unifiedFieldList.cleanSidebarLocalStorage();
       await kibanaServer.savedObjects.cleanStandardList();
+      await PageObjects.svlCommonPage.forceLogout();
     });
 
     describe('existence', () => {

diff --git a/x-pack/test_serverless/functional/test_suites/common/home_page/home_page.ts b/x-pack/test_serverless/functional/test_suites/common/home_page/home_page.ts
@@ -11,9 +11,15 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
   const svlCommonPage = getPageObject('svlCommonPage');
   const svlCommonNavigation = getService('svlCommonNavigation');
 
-  // Failing: See https://github.com/elastic/kibana/issues/165386
-  // FLAKY: https://github.com/elastic/kibana/issues/165414
-  describe.skip('home page', function () {
+  describe('home page', function () {
+    before(async () => {
+      await svlCommonPage.login();
+    });
+
+    after(async () => {
+      await svlCommonPage.forceLogout();
+    });
+
     it('has project header', async () => {
       await svlCommonNavigation.navigateToKibanaHome();
       await svlCommonPage.assertProjectHeaderExists();

diff --git a/...verless/functional/test_suites/common/management/index_management/create_enrich_policy.ts b/...verless/functional/test_suites/common/management/index_management/create_enrich_policy.ts
@@ -21,7 +21,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
 
   describe('Create enrich policy', function () {
     before(async () => {
-      await log.debug('Creating test index');
+      log.debug('Creating test index');
       try {
         await es.indices.create({
           index: INDEX_NAME,
@@ -43,7 +43,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         throw e;
       }
 
-      await log.debug('Navigating to the enrich policies tab');
+      log.debug('Navigating to the enrich policies tab');
       await pageObjects.svlCommonPage.login();
       await security.testUser.setRoles(['index_management_user']);
       await pageObjects.common.navigateToApp('indexManagement');
@@ -56,7 +56,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
     });
 
     after(async () => {
-      await log.debug('Cleaning up created index');
+      log.debug('Cleaning up created index');
 
       try {
         await es.indices.delete({ index: INDEX_NAME });

diff --git a/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts b/x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts
@@ -17,8 +17,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
   const cases = getService('cases');
   const toasts = getService('toasts');
 
-  // Failing: See https://github.com/elastic/kibana/issues/166448
-  describe.skip('Configure Case', function () {
+  describe('Configure Case', function () {
     before(async () => {
       await svlCommonPage.login();
 

diff --git a/...ck/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts b/...ck/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts
@@ -7,11 +7,22 @@
 import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
-export default function ({ getService, getPageObjects }: FtrProviderContext) {
-  const PageObjects = getPageObjects(['observabilityLogExplorer', 'svlCommonNavigation']);
+export default function ({ getPageObjects }: FtrProviderContext) {
+  const PageObjects = getPageObjects([
+    'observabilityLogExplorer',
+    'svlCommonNavigation',
+    'svlCommonPage',
+  ]);
+
+  describe('Application', () => {
+    before(async () => {
+      await PageObjects.svlCommonPage.login();
+    });
+
+    after(async () => {
+      await PageObjects.svlCommonPage.forceLogout();
+    });
 
-  // FLAKY: https://github.com/elastic/kibana/issues/165943
-  describe.skip('Application', () => {
     it('is shown in the global search', async () => {
       await PageObjects.observabilityLogExplorer.navigateTo();
       await PageObjects.svlCommonNavigation.search.showSearch();

diff --git a/...erless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts b/...erless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts
@@ -11,8 +11,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const PageObjects = getPageObjects(['observabilityLogExplorer', 'svlCommonPage']);
   const testSubjects = getService('testSubjects');
 
-  // Failing: See https://github.com/elastic/kibana/issues/166461
-  describe.skip('Filter controls customization', () => {
+  describe('Filter controls customization', () => {
     before('initialize tests', async () => {
       await PageObjects.svlCommonPage.login();
       await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');

diff --git a/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts b/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts
@@ -16,8 +16,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
   const cases = getService('cases');
   const toasts = getService('toasts');
 
-  // Failing: See https://github.com/elastic/kibana/issues/166551
-  describe.skip('Configure Case', function () {
+  describe('Configure Case', function () {
     before(async () => {
       await svlCommonPage.login();