-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Response Ops] Rule Specific Flapping - Create/Edit Rule Flyout Front…
…end Changes (#189341) ## Summary Issue: #189135 Frontend changes for the rule specific flapping feature in the existing rule flyout. To test: Simply go to `x-pack/plugins/triggers_actions_ui/public/common/constants/index.ts` and set line 89 `IS_RULE_SPECIFIC_FLAPPING_ENABLED = false` to `true`. This acts as a feature flag. Then you may go to the create/edit rule flyout to see this new input. This PR does not contain changes to allow for saving/editing of this field. That will come with the backend PR. ### Flapping Enabled Without Override <img width="648" alt="Screenshot 2024-07-29 at 12 11 02 AM" src="https://github.com/user-attachments/assets/82b552c5-faf3-459f-a22d-69ea95292d89"> ### Flapping Enabled With Override <img width="652" alt="Screenshot 2024-07-29 at 12 11 07 AM" src="https://github.com/user-attachments/assets/2d305570-8cd6-4488-af5b-8c78cb3c2b3a"> ### Flapping Disabled With or Without Override <img width="652" alt="image" src="https://github.com/user-attachments/assets/5bb76e6a-85e5-4992-a37f-a737d083ec54"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- Loading branch information
1 parent
01aae23
commit a2873c0
Showing
31 changed files
with
1,143 additions
and
305 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
export const MIN_LOOK_BACK_WINDOW = 2; | ||
export const MAX_LOOK_BACK_WINDOW = 20; | ||
export const MIN_STATUS_CHANGE_THRESHOLD = 2; | ||
export const MAX_STATUS_CHANGE_THRESHOLD = 20; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.