Skip to content

Commit

Permalink
Removes skip from inner tests where the outer test is already skipped
Browse files Browse the repository at this point in the history
  • Loading branch information
TinaHeiligers committed Oct 16, 2023
1 parent 9afb46a commit a98a8ea
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions test/functional/apps/dashboard/group5/embed_mode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ export default function ({
await testSubjects.missingOrFail('superDatePickerToggleQuickMenuButton');
await testSubjects.existOrFail('globalQueryBar');
});
// failed test. See https://github.com/elastic/kibana/issues/163207
it.skip('renders as expected', async () => {

it('renders as expected', async () => {
await PageObjects.dashboard.waitForRenderComplete();
const percentDifference = await screenshot.compareAgainstBaseline(
'dashboard_embed_mode',
Expand Down
4 changes: 2 additions & 2 deletions test/functional/apps/discover/group1/_shared_links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
return true;
});
});
// Failed test. See https://github.com/elastic/kibana/issues/167405
it.skip("sharing hashed url shouldn't crash the app", async () => {

it("sharing hashed url shouldn't crash the app", async () => {
const currentUrl = await browser.getCurrentUrl();
await browser.clearSessionStorage();
await browser.get(currentUrl, false);
Expand Down

0 comments on commit a98a8ea

Please sign in to comment.