Skip to content

Commit

Permalink
updates comments in e2e tests for import rules route
Browse files Browse the repository at this point in the history
  • Loading branch information
dhurley14 committed Sep 17, 2020
1 parent fe888cf commit acfb15d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export default ({ getService }: FtrProviderContext): void => {
});
});

// import is still very slow due to the alerts client find api
// import is very slow in 7.10+ due to the alerts client find api
// when importing 100 rules it takes about 30 seconds for this
// test to complete so at 10 rules completing in about 10 seconds
// I figured this is enough to make sure the import route is doing its job.
Expand All @@ -212,6 +212,7 @@ export default ({ getService }: FtrProviderContext): void => {
});

// uncomment the below test once we speed up the alerts client find api
// in another PR.
// it('should be able to import 10000 rules', async () => {
// const ruleIds = new Array(10000).fill(undefined).map((_, index) => `rule-${index}`);
// const { body } = await supertest
Expand Down

0 comments on commit acfb15d

Please sign in to comment.