Removing todo and fixing test

elastic · Sep 10, 2020 · b14cb3b · b14cb3b
1 parent f2909b1
commit b14cb3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/common/endpoint/generate_data.test.ts b/x-pack/plugins/security_solution/common/endpoint/generate_data.test.ts
@@ -433,8 +433,14 @@ describe('data generator', () => {
         tree[value.parent_entity_id].children.push(value);
       }
     }
+
+    const entityID = entityIDSafeVersion(events[0]);
+    if (!entityID) {
+      throw new Error('entity id was invalid');
+    }
+
     // The root node must be first in the array or this fails
-    return tree[entityIDSafeVersion(events[0]) ?? ''];
+    return tree[entityID];
   }
 
   function countResolverEvents(rootNode: Node, generations: number): number {

diff --git a/x-pack/plugins/security_solution/common/endpoint/models/event.test.ts b/x-pack/plugins/security_solution/common/endpoint/models/event.test.ts
@@ -13,8 +13,6 @@ describe('Generated documents', () => {
     generator = new EndpointDocGenerator('seed');
   });
 
-  // TODO what should I do about the cast? We can create a new safe descriptive name but
-  // the front end won't use that until the rest of it is converted
   describe('Event descriptive names', () => {
     it('returns the right name for a registry event', () => {
       const extensions = { registry: { key: `HKLM/Windows/Software/abc` } };