-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sustainable Kibana Architecture: Categorise
straightforward
packages (
#199630) ## Summary This PR is part of the Kibana Sustainable Architecture effort. The goal is to start categorising Kibana packages into _generic platform_ (`group: "platform"`) vs _solution-specific_. ``` group?: 'search' | 'security' | 'observability' | 'platform' visibility?: 'private' | 'shared' ``` Uncategorised modules are considered to be `group: 'common', visibility: 'shared'` by default. We want to prevent code from solution A to depend on code from solution B. Thus, the rules are pretty simple: * Modules can only depend on: * Modules in the same group * OR modules with 'shared' visibility * Modules in `'observability', 'security', 'search'` groups are mandatorily `visibility: "private"`. Long term, the goal is to re-organise packages into dedicated folders, e.g.: ``` x-pack/platform/plugins/private x-pack/observability/packages ``` For this first wave, we have categorised packages that seem "straightforward": * Any packages that have: * at least one dependant module * all dependants belong to the same group * Categorise all Core packages: * `@kbn/core-...-internal` => _platform/private_ * everything else => _platform/shared_ * Categorise as _platform/shared_ those packages that: * Have at least one dependant in the _platform_ group. * Don't have any `devOnly: true` dependants. ### What we ask from you, as CODEOWNERS of the _package manifests_, is that you confirm that the categorisation is correct: * `group: "platform", visibility: "private"` if it's a package that should only be used from platform code, not from any solution code. It will be loaded systematically in all serverless flavors, but solution plugins and packages won't be able to `import` from it. * `group: "platform", visibility: "shared"` if it's a package that can be consumed by both platform and solutions code. It will be loaded systematically in all serverless flavors, and anybody can import / use code from it. * `group: "observability" | "security" | "search", visibility: "private"` if it's a package that is intented to be used exclusively from a given solution. It won't be accessible nor loaded from other solutions nor platform code. Please refer to [#kibana-sustainable-architecture](https://elastic.slack.com/archives/C07TCKTA22E) for any related questions. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information
1 parent
e42569d
commit b24fdf5
Showing
675 changed files
with
4,048 additions
and
1,532 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
packages/analytics/utils/analytics_collection_utils/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-common", | ||
"id": "@kbn/analytics-collection-utils", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-common", | ||
"id": "@kbn/cloud", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-content-editor", | ||
"owner": "@elastic/appex-sharedux", | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/content_insights/content_insights_public/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-content-insights-public", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/content_insights/content_insights_server/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-server", | ||
"id": "@kbn/content-management-content-insights-server", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
4 changes: 3 additions & 1 deletion
4
packages/content-management/favorites/favorites_common/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"type": "shared-common", | ||
"id": "@kbn/content-management-favorites-common", | ||
"owner": "@elastic/appex-sharedux" | ||
"owner": "@elastic/appex-sharedux", | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/favorites/favorites_public/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-favorites-public", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/favorites/favorites_server/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-server", | ||
"id": "@kbn/content-management-favorites-server", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/tabbed_table_list_view/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-tabbed-table-list-view", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-table-list-view", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/table_list_view_common/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-common", | ||
"id": "@kbn/content-management-table-list-view-common", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/content-management/table_list_view_table/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-table-list-view-table", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/content-management-user-profiles", | ||
"owner": "@elastic/appex-sharedux" | ||
} | ||
"owner": [ | ||
"@elastic/appex-sharedux" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/core/analytics/core-analytics-browser-internal/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/core-analytics-browser-internal", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
10 changes: 7 additions & 3 deletions
10
packages/core/analytics/core-analytics-browser-mocks/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/core-analytics-browser-mocks", | ||
"devOnly": true, | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "shared", | ||
"devOnly": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/core-analytics-browser", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/core/analytics/core-analytics-server-internal/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-server", | ||
"id": "@kbn/core-analytics-server-internal", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
10 changes: 7 additions & 3 deletions
10
packages/core/analytics/core-analytics-server-mocks/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
{ | ||
"type": "shared-server", | ||
"id": "@kbn/core-analytics-server-mocks", | ||
"devOnly": true, | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "shared", | ||
"devOnly": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-server", | ||
"id": "@kbn/core-analytics-server", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "shared" | ||
} |
8 changes: 6 additions & 2 deletions
8
packages/core/application/core-application-browser-internal/kibana.jsonc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
{ | ||
"type": "shared-browser", | ||
"id": "@kbn/core-application-browser-internal", | ||
"owner": "@elastic/kibana-core" | ||
} | ||
"owner": [ | ||
"@elastic/kibana-core" | ||
], | ||
"group": "platform", | ||
"visibility": "private" | ||
} |
Oops, something went wrong.