Improve variable

elastic · Sep 16, 2020 · b2f5d9d · b2f5d9d
1 parent 7185d51
commit b2f5d9d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/link_to/index.ts b/x-pack/plugins/security_solution/public/common/components/link_to/index.ts
@@ -27,7 +27,7 @@ export {
 
 interface FormatUrlOptions {
   absolute: boolean;
-  addSearch: boolean;
+  skipSearch: boolean;
 }
 
 type FormatUrl = (path: string, options?: Partial<FormatUrlOptions>) => string;
@@ -36,10 +36,10 @@ export const useFormatUrl = (page: SecurityPageName) => {
   const { getUrlForApp } = useKibana().services.application;
   const search = useGetUrlSearch(navTabs[page]);
   const formatUrl = useCallback<FormatUrl>(
-    (path: string, { absolute, addSearch } = { absolute: false, addSearch: true }) => {
+    (path: string, { absolute = false, skipSearch = false } = {}) => {
       const pathArr = path.split('?');
       const formattedPath = `${pathArr[0]}${
-        addSearch
+        !skipSearch
           ? isEmpty(pathArr[1])
             ? search
             : `?${pathArr[1]}${isEmpty(search) ? '' : `&${search}`}`

diff --git a/...ns/security_solution/public/common/components/markdown_editor/plugins/timeline/plugin.tsx b/...ns/security_solution/public/common/components/markdown_editor/plugins/timeline/plugin.tsx
@@ -55,7 +55,7 @@ const TimelineEditorComponent: React.FC<TimelineEditorProps> = ({ onClosePopover
         onTimelineChange={(timelineTitle, timelineId, graphEventId) => {
           const url = formatUrl(getTimelineUrl(timelineId ?? '', graphEventId), {
             absolute: true,
-            addSearch: false,
+            skipSearch: true,
           });
           onInsert(`[${timelineTitle}](${url})`, {
             block: false,

diff --git a/...tion/public/timelines/components/timeline/insert_timeline_popover/use_insert_timeline.tsx b/...tion/public/timelines/components/timeline/insert_timeline_popover/use_insert_timeline.tsx
@@ -26,7 +26,7 @@ export const useInsertTimeline = (value: string, onChange: (newValue: string) =>
     (title: string, id: string | null, graphEventId?: string) => {
       const url = formatUrl(getTimelineUrl(id ?? '', graphEventId), {
         absolute: true,
-        addSearch: false,
+        skipSearch: true,
       });
 
       const newValue: string = [