Refactor filter_ratio.js

elastic · Aug 21, 2020 · b682341 · b682341
1 parent 60081d8
commit b682341
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js b/src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js
@@ -54,9 +54,13 @@ export const FilterRatioAgg = (props) => {
     props.onChange,
   ]);
   const handleSelectChange = createSelectHandler(handleChange);
-  const handleQueryChange = useCallback((name, value) => handleChange({ [name]: value }), [
+  const handleNumeratorQueryChange = useCallback((query) => handleChange({ numerator: query }), [
     handleChange,
   ]);
+  const handleDenominatorQueryChange = useCallback(
+    (query) => handleChange({ denominator: query }),
+    [handleChange]
+  );
   const indexPattern =
     (series.override_index_pattern && series.series_index_pattern) || panel.index_pattern;
 
@@ -108,7 +112,7 @@ export const FilterRatioAgg = (props) => {
           >
             <QueryBarWrapper
               query={model.numerator}
-              onChange={(query) => handleQueryChange('numerator', query)}
+              onChange={handleNumeratorQueryChange}
               indexPatterns={[indexPattern]}
             />
           </EuiFormRow>
@@ -126,7 +130,7 @@ export const FilterRatioAgg = (props) => {
           >
             <QueryBarWrapper
               query={model.denominator}
-              onChange={(query) => handleQueryChange('denominator', query)}
+              onChange={handleDenominatorQueryChange}
               indexPatterns={[indexPattern]}
             />
           </EuiFormRow>