Add autocomplete="off" for input type="password" to appease the scann…

…ers (#56922) * Add autocomplete="off" for input type="password" to appease the scanners * Using new-password instead of off for the new/confirm passwords * Setting more autoComplete="new-password" attributes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elastic · Feb 13, 2020 · bc8a41a · bc8a41a
1 parent fef3a29
commit bc8a41a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 0 deletions.
diff --git a/...blic/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap b/...blic/views/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap
diff --git a/...gacy/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx b/...gacy/plugins/security/public/views/login/components/basic_login_form/basic_login_form.tsx
@@ -75,6 +75,7 @@ class BasicLoginFormUI extends Component<Props, State> {
               }
             >
               <EuiFieldText
+                autoComplete="off"
                 id="password"
                 name="password"
                 data-test-subj="loginPassword"

diff --git a/...security/public/management/users/components/change_password_form/change_password_form.tsx b/...security/public/management/users/components/change_password_form/change_password_form.tsx
@@ -72,6 +72,7 @@ export class ChangePasswordForm extends Component<Props, State> {
             }
           >
             <EuiFieldText
+              autoComplete="off"
               data-test-subj="currentPassword"
               type="password"
               value={this.state.currentPassword}
@@ -99,6 +100,7 @@ export class ChangePasswordForm extends Component<Props, State> {
           }
         >
           <EuiFieldText
+            autoComplete="new-password"
             data-test-subj="newPassword"
             type="password"
             value={this.state.newPassword}
@@ -118,6 +120,7 @@ export class ChangePasswordForm extends Component<Props, State> {
           }
         >
           <EuiFieldText
+            autoComplete="new-password"
             data-test-subj="confirmNewPassword"
             type="password"
             value={this.state.confirmPassword}

diff --git a/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx b/x-pack/plugins/security/public/management/users/edit_user/edit_user_page.tsx
@@ -204,6 +204,7 @@ export class EditUserPage extends Component<Props, State> {
           {...this.validator.validatePassword(this.state.user)}
         >
           <EuiFieldText
+            autoComplete="new-password"
             data-test-subj="passwordInput"
             name="password"
             type="password"
@@ -218,6 +219,7 @@ export class EditUserPage extends Component<Props, State> {
           {...this.validator.validateConfirmPassword(this.state.user)}
         >
           <EuiFieldText
+            autoComplete="new-password"
             data-test-subj="passwordConfirmationInput"
             onChange={this.onConfirmPasswordChange}
             name="confirm_password"