AddFile disabled if user has no create permission.

elastic · Mar 27, 2023 · bccf790 · bccf790
1 parent 9fefef4
commit bccf790
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 22 deletions.
diff --git a/x-pack/plugins/cases/public/components/files/add_file.test.tsx b/x-pack/plugins/cases/public/components/files/add_file.test.tsx
@@ -16,6 +16,7 @@ import type { AppMockRenderer } from '../../common/mock';
 
 import { constructFileKindIdByOwner } from '../../../common/constants';
 import {
+  buildCasesPermissions,
   createAppMockRenderer,
   mockedTestProvidersOwner,
   mockedFilesClient,
@@ -107,6 +108,16 @@ describe('AddFile', () => {
     expect(await screen.findByTestId('cases-files-add')).toBeInTheDocument();
   });
 
+  it('add button disable if user has no creat permission', async () => {
+    appMockRender = createAppMockRenderer({
+      permissions: buildCasesPermissions({ create: false }),
+    });
+
+    appMockRender.render(<AddFile caseId={'foobar'} />);
+
+    expect(await screen.findByTestId('cases-files-add')).toBeDisabled();
+  });
+
   it('clicking button renders modal', async () => {
     appMockRender.render(<AddFile caseId={'foobar'} />);
 

diff --git a/x-pack/plugins/cases/public/components/files/add_file.tsx b/x-pack/plugins/cases/public/components/files/add_file.tsx
@@ -36,7 +36,7 @@ interface AddFileProps {
 }
 
 const AddFileComponent: React.FC<AddFileProps> = ({ caseId }) => {
-  const { owner } = useCasesContext();
+  const { owner, permissions } = useCasesContext();
   const { client: filesClient } = useFilesContext();
   const { showDangerToast, showErrorToast, showSuccessToast } = useCasesToast();
   const { isLoading, createAttachments } = useCreateAttachments();
@@ -122,7 +122,7 @@ const AddFileComponent: React.FC<AddFileProps> = ({ caseId }) => {
       <EuiButton
         data-test-subj="cases-files-add"
         iconType="plusInCircle"
-        isDisabled={isLoading}
+        isDisabled={isLoading || !permissions.create}
         isLoading={isLoading}
         onClick={showModal}
       >

diff --git a/x-pack/plugins/cases/public/components/files/file_preview.test.tsx b/x-pack/plugins/cases/public/components/files/file_preview.test.tsx
@@ -7,7 +7,6 @@
 import React from 'react';
 
 import { screen, waitFor } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
 
 import type { AppMockRenderer } from '../../common/mock';
 
@@ -44,23 +43,4 @@ describe('FilePreview', () => {
 
     expect(await screen.findByTestId('cases-files-image-preview')).toBeInTheDocument();
   });
-
-  // I cannot get this test to work
-  it.skip('clicking outside Image triggers closePreview', () => {
-    const mockClosePreview = jest.fn();
-
-    appMockRender.render(
-      <>
-        <div data-test-subj="outsideClickDummy" />
-        <FilePreview
-          closePreview={mockClosePreview}
-          selectedFile={basicFileMock}
-          getDownloadHref={jest.fn()}
-        />
-      </>
-    );
-
-    userEvent.click(screen.getByTestId('outsideClickDummy'));
-    expect(mockClosePreview).toBeCalled();
-  });
 });