functional test for short url 404

.buildkite/ftr_configs.yml

@@ -124,6 +124,7 @@ enabled:
   - test/functional/apps/kibana_overview/config.ts
   - test/functional/apps/management/config.ts
   - test/functional/apps/saved_objects_management/config.ts
+  - test/functional/apps/sharing/config.ts
   - test/functional/apps/status_page/config.ts
   - test/functional/apps/visualize/group1/config.ts
   - test/functional/apps/visualize/group2/config.ts

src/plugins/share/public/url_service/redirect/components/empty_prompt.tsx

@@ -9,7 +9,6 @@
 import * as React from 'react';
 
 import { EuiButtonEmpty } from '@elastic/eui';
-import { HttpStart } from '@kbn/core/public';
 import { i18n } from '@kbn/i18n';
 import { NotFoundPrompt } from '@kbn/shared-ux-prompt-not-found';
 
@@ -28,7 +27,6 @@ export interface ErrorProps {
   title?: string;
   body?: string;
   error: Error;
-  http: HttpStart;
 }
 
 export const RedirectEmptyPrompt: React.FC<ErrorProps> = ({
@@ -39,14 +37,19 @@ export const RedirectEmptyPrompt: React.FC<ErrorProps> = ({
   // eslint-disable-next-line no-console
   console.error('Short URL Redirect Error', props.error);
 
+  // Using the current URL containing "/app/r/", make a URL to the root basePath
+  // by trimming that part to end up at the Home app or project home.
+  const currentUrl = window.location.href;
+  const newUrl = currentUrl.replace(/\/app\/r\/.*/, '');
+
   return (
     <NotFoundPrompt
       title={<h2>{title}</h2>}
       body={<p data-test-subj="redirectErrorEmptyPromptBody">{body}</p>}
       actions={
         <EuiButtonEmpty
           iconType="arrowLeft"
-          href={props.http.basePath.get()}
+          href={newUrl}
           data-test-subj="redirectErrorEmptyPromptButton"
         >
           {i18n.translate('share.urlService.redirect.components.Error.homeButton', {

src/plugins/share/public/url_service/redirect/components/page.tsx

@@ -11,7 +11,7 @@ import useObservable from 'react-use/lib/useObservable';
 
 import { EuiPageTemplate } from '@elastic/eui';
 import type { CustomBrandingStart } from '@kbn/core-custom-branding-browser';
-import type { HttpStart, ThemeServiceSetup } from '@kbn/core/public';
+import type { ThemeServiceSetup } from '@kbn/core/public';
 import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
 
 import type { RedirectManager } from '../redirect_manager';
@@ -20,20 +20,19 @@ import { Spinner } from './spinner';
 
 export interface PageProps {
   customBranding: CustomBrandingStart;
-  http: HttpStart;
   manager: Pick<RedirectManager, 'error$'>;
   theme: ThemeServiceSetup;
 }
 
-export const Page: React.FC<PageProps> = ({ manager, http, theme, customBranding }) => {
+export const Page: React.FC<PageProps> = ({ manager, theme, customBranding }) => {
   const error = useObservable(manager.error$);
   const hasCustomBranding = useObservable(customBranding.hasCustomBranding$);
 
   if (error) {
     return (
       <KibanaThemeProvider theme={{ theme$: theme.theme$ }}>
         <EuiPageTemplate>
-          <RedirectEmptyPrompt error={error} http={http} />
+          <RedirectEmptyPrompt error={error} />
         </EuiPageTemplate>
       </KibanaThemeProvider>
     );

src/plugins/share/public/url_service/redirect/redirect_manager.ts

@@ -36,7 +36,6 @@ export class RedirectManager {
         const { render } = await import('./render');
         const unmount = render(params.element, {
           manager: this,
-          http: core.http,
           theme: core.theme,
           customBranding: core.customBranding,
         });

test/functional/apps/sharing/_short_urls.ts

@@ -0,0 +1,47 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getPageObjects, getService }: FtrProviderContext) {
+  const PageObjects = getPageObjects(['common']);
+  const browser = getService('browser');
+  const log = getService('log');
+  const testSubjects = getService('testSubjects');
+  const retry = getService('retry');
+
+  describe('Short URLs', () => {
+    it('opening a missing short URL shows empty prompt', async () => {
+      await PageObjects.common.navigateToApp('home');
+
+      log.info('Navigating to Home...');
+      await retry.try(async () => {
+        const title = await browser.getTitle();
+        expect(title).to.be('Home - Elastic');
+      });
+
+      log.info('Changing URL to missing short URL...');
+      const currentUrl = await browser.getCurrentUrl();
+      const newUrl = currentUrl.replace(/\/app\/home/, '/app/r/s/foofoo');
+      await browser.get(newUrl);
+
+      await retry.try(async () => {
+        await testSubjects.existOrFail('redirectErrorEmptyPromptBody');
+      });
+
+      log.info('Clicking the prompt button...');
+      await testSubjects.click('redirectErrorEmptyPromptButton');
+
+      await retry.try(async () => {
+        const title = await browser.getTitle();
+        expect(title).to.be('Home - Elastic');
+      });
+    });
+  });
+}

test/functional/apps/sharing/config.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { FtrConfigProviderContext } from '@kbn/test';
+
+export default async function ({ readConfigFile }: FtrConfigProviderContext) {
+  const functionalConfig = await readConfigFile(require.resolve('../../config.base.js'));
+
+  return {
+    ...functionalConfig.getAll(),
+    testFiles: [require.resolve('.')],
+  };
+}

test/functional/apps/sharing/index.ts

@@ -0,0 +1,15 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ loadTestFile }: FtrProviderContext) {
+  describe('Sharing features', () => {
+    loadTestFile(require.resolve('./_short_urls'));
+  });
+}

x-pack/test_serverless/functional/test_suites/common/sharing/_short_urls.ts

@@ -0,0 +1,46 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../../ftr_provider_context';
+
+export default function ({ getPageObjects, getService }: FtrProviderContext) {
+  const PageObjects = getPageObjects(['common']);
+  const browser = getService('browser');
+  const log = getService('log');
+  const testSubjects = getService('testSubjects');
+  const retry = getService('retry');
+
+  describe('Short URLs', () => {
+    it('opening a missing short URL shows empty prompt', async () => {
+      await PageObjects.common.navigateToApp('home');
+
+      log.info('Navigating to Home...');
+      await retry.try(async () => {
+        const title = await browser.getTitle();
+        expect(title).to.be('Home - Elastic');
+      });
+
+      log.info('Changing URL to missing short URL...');
+      const currentUrl = await browser.getCurrentUrl();
+      const newUrl = currentUrl.replace(/\/app\/home/, '/app/r/s/foofoo');
+      await browser.get(newUrl);
+
+      await retry.try(async () => {
+        await testSubjects.existOrFail('redirectErrorEmptyPromptBody');
+      });
+
+      log.info('Clicking the prompt button...');
+      await testSubjects.click('redirectErrorEmptyPromptButton');
+
+      await retry.try(async () => {
+        const title = await browser.getTitle();
+        expect(title).to.be('Home - Elastic');
+      });
+    });
+  });
+}

x-pack/test_serverless/functional/test_suites/common/sharing/index.ts

@@ -0,0 +1,14 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { FtrProviderContext } from '../../../ftr_provider_context';
+
+export default ({ loadTestFile }: FtrProviderContext) => {
+  describe('Sharing features', function () {
+    loadTestFile(require.resolve('./_short_urls'));
+  });
+};

x-pack/test_serverless/functional/test_suites/observability/common_configs/config.group1.ts

@@ -17,6 +17,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
       require.resolve('../../common/management'),
       require.resolve('../../common/platform_security'),
       require.resolve('../../common/reporting'),
+      require.resolve('../../common/sharing'),
     ],
     junit: {
       reportName: 'Serverless Observability Functional Tests - Common Group 1',

x-pack/test_serverless/functional/test_suites/search/common_configs/config.group1.ts

@@ -17,6 +17,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
       require.resolve('../../common/management'),
       require.resolve('../../common/platform_security'),
       require.resolve('../../common/reporting'),
+      require.resolve('../../common/sharing'),
     ],
     junit: {
       reportName: 'Serverless Search Functional Tests - Common Group 1',

x-pack/test_serverless/functional/test_suites/security/common_configs/config.group1.ts

@@ -17,6 +17,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
       require.resolve('../../common/management'),
       require.resolve('../../common/platform_security'),
       require.resolve('../../common/reporting'),
+      require.resolve('../../common/sharing'),
     ],
     junit: {
       reportName: 'Serverless Security Functional Tests - Common Group 1',