Skip to content

Commit

Permalink
[testSubjects] remove unnecessary method
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed Feb 15, 2019
1 parent aa50534 commit c2bc142
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion test/functional/services/filter_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function FilterBarProvider({ getService, getPageObjects }) {
class FilterBar {
hasFilter(key, value, enabled = true) {
const filterActivationState = enabled ? 'enabled' : 'disabled';
return testSubjects.existsInDOM(
return testSubjects.exists(
`filter & filter-key-${key} & filter-value-${value} & filter-${filterActivationState}`
);
}
Expand Down
5 changes: 0 additions & 5 deletions test/functional/services/test_subjects.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ export function TestSubjectsProvider({ getService }) {
);
}

async existsInDOM(selector, timeout = WAIT_FOR_EXISTS_TIME) {
log.debug(`TestSubjects.existsInDOM(${selector})`);
return await find.existsByCssSelector(testSubjSelector(selector), timeout);
}

async existOrFail(selector, existsOptions) {
if (!await this.exists(selector, { timeout: TRY_TIME, ...existsOptions })) {
throw new Error(`expected testSubject(${selector}) to exist`);
Expand Down

0 comments on commit c2bc142

Please sign in to comment.