-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Endpoint] Prevent event filter list to be created…
… twice from policy details page. (#123350) * Adds new module with service actions to be used in the service class and in the hooks without using the class. Also marks the class as deprecated. * New service actions to be used in service class and hooks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information
1 parent
b1d7731
commit c5aa390
Showing
5 changed files
with
185 additions
and
110 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
148 changes: 148 additions & 0 deletions
148
...lugins/security_solution/public/management/pages/event_filters/service/service_actions.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,148 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { | ||
| CreateExceptionListItemSchema, | ||
| ExceptionListItemSchema, | ||
| ExceptionListSummarySchema, | ||
| FoundExceptionListItemSchema, | ||
| UpdateExceptionListItemSchema, | ||
| } from '@kbn/securitysolution-io-ts-list-types'; | ||
| import { HttpStart } from 'kibana/public'; | ||
| import { | ||
| EXCEPTION_LIST_ITEM_URL, | ||
| EXCEPTION_LIST_URL, | ||
| EVENT_FILTER_LIST, | ||
| ENDPOINT_EVENT_FILTERS_LIST_ID, | ||
| } from '../constants'; | ||
| import { Immutable } from '../../../../../common/endpoint/types'; | ||
|
|
||
| async function createEventFilterList(http: HttpStart): Promise<void> { | ||
| try { | ||
| await http.post<ExceptionListItemSchema>(EXCEPTION_LIST_URL, { | ||
| body: JSON.stringify(EVENT_FILTER_LIST), | ||
| }); | ||
| } catch (err) { | ||
| // Ignore 409 errors. List already created | ||
| if (err.response?.status !== 409) { | ||
| throw err; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| let listExistsPromise: Promise<void>; | ||
| export async function ensureEventFiltersListExists(http: HttpStart): Promise<void> { | ||
| if (!listExistsPromise) { | ||
| listExistsPromise = createEventFilterList(http); | ||
| } | ||
| await listExistsPromise; | ||
| } | ||
|
|
||
| export async function getList({ | ||
| http, | ||
| perPage, | ||
| page, | ||
| sortField, | ||
| sortOrder, | ||
| filter, | ||
| }: { | ||
| http: HttpStart; | ||
| page?: number; | ||
| perPage?: number; | ||
| sortField?: string; | ||
| sortOrder?: string; | ||
| filter?: string; | ||
| }): Promise<FoundExceptionListItemSchema> { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.get(`${EXCEPTION_LIST_ITEM_URL}/_find`, { | ||
| query: { | ||
| page, | ||
| per_page: perPage, | ||
| sort_field: sortField, | ||
| sort_order: sortOrder, | ||
| list_id: [ENDPOINT_EVENT_FILTERS_LIST_ID], | ||
| namespace_type: ['agnostic'], | ||
| filter, | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export async function addEventFilters( | ||
| http: HttpStart, | ||
| exception: ExceptionListItemSchema | CreateExceptionListItemSchema | ||
| ) { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.post<ExceptionListItemSchema>(EXCEPTION_LIST_ITEM_URL, { | ||
| body: JSON.stringify(exception), | ||
| }); | ||
| } | ||
|
|
||
| export async function getOne(http: HttpStart, id: string) { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.get<ExceptionListItemSchema>(EXCEPTION_LIST_ITEM_URL, { | ||
| query: { | ||
| id, | ||
| namespace_type: 'agnostic', | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export async function updateOne( | ||
| http: HttpStart, | ||
| exception: Immutable<UpdateExceptionListItemSchema> | ||
| ): Promise<ExceptionListItemSchema> { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.put<ExceptionListItemSchema>(EXCEPTION_LIST_ITEM_URL, { | ||
| body: JSON.stringify(cleanEventFilterToUpdate(exception)), | ||
| }); | ||
| } | ||
|
|
||
| export async function deleteOne(http: HttpStart, id: string): Promise<ExceptionListItemSchema> { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.delete<ExceptionListItemSchema>(EXCEPTION_LIST_ITEM_URL, { | ||
| query: { | ||
| id, | ||
| namespace_type: 'agnostic', | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export async function getSummary(http: HttpStart): Promise<ExceptionListSummarySchema> { | ||
| await ensureEventFiltersListExists(http); | ||
| return http.get<ExceptionListSummarySchema>(`${EXCEPTION_LIST_URL}/summary`, { | ||
| query: { | ||
| list_id: ENDPOINT_EVENT_FILTERS_LIST_ID, | ||
| namespace_type: 'agnostic', | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export function cleanEventFilterToUpdate( | ||
| exception: Immutable<UpdateExceptionListItemSchema> | ||
| ): UpdateExceptionListItemSchema { | ||
| const exceptionToUpdateCleaned = { ...exception }; | ||
| // Clean unnecessary fields for update action | ||
| [ | ||
| 'created_at', | ||
| 'created_by', | ||
| 'created_at', | ||
| 'created_by', | ||
| 'list_id', | ||
| 'tie_breaker_id', | ||
| 'updated_at', | ||
| 'updated_by', | ||
| ].forEach((field) => { | ||
| delete exceptionToUpdateCleaned[field as keyof UpdateExceptionListItemSchema]; | ||
| }); | ||
|
|
||
| exceptionToUpdateCleaned.comments = exceptionToUpdateCleaned.comments?.map((comment) => ({ | ||
| comment: comment.comment, | ||
| id: comment.id, | ||
| })); | ||
|
|
||
| return exceptionToUpdateCleaned as UpdateExceptionListItemSchema; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.