Skip to content

Commit

Permalink
[Reporting] Unskip flaky test when downloading CSV with "no data" (#1…
Browse files Browse the repository at this point in the history
…05252) (#106210)

* unskipped test and added additional checks when using time picker

* rather wait for the timepicker to close

* set up test for flaky test runner

* Additional .only

* Remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
  • Loading branch information
kibanamachine and jloleysens authored Jul 20, 2021
1 parent d7072ea commit ce4fee9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions test/functional/page_objects/time_picker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ export class TimePickerPageObject extends FtrService {
await this.testSubjects.click('superDatePickerAbsoluteTab');
await this.testSubjects.click('superDatePickerAbsoluteDateInput');
await this.inputValue('superDatePickerAbsoluteDateInput', fromTime);
await this.browser.pressKeys(this.browser.keys.ESCAPE);

await this.retry.waitFor('Timepicker popover to close', async () => {
return !(await this.testSubjects.exists('superDatePickerAbsoluteDateInput'));
});

const superDatePickerApplyButtonExists = await this.testSubjects.exists(
'superDatePickerApplyTimeButton'
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/discover/reporting.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/104372
describe.skip('Generate CSV: new search', () => {
describe('Generate CSV: new search', () => {
beforeEach(async () => {
await kibanaServer.importExport.load(ecommerceSOPath);
await PageObjects.common.navigateToApp('discover');
Expand Down

0 comments on commit ce4fee9

Please sign in to comment.