Fix wrong suggestion

elastic · Nov 5, 2024 · cf707f8 · cf707f8
1 parent 6daa2c8
commit cf707f8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 15 deletions.
diff --git a/packages/kbn-visualization-utils/src/map_vis_to_chart_type.ts b/packages/kbn-visualization-utils/src/map_vis_to_chart_type.ts
@@ -14,13 +14,13 @@ type LensToChartMap = {
   [K in ValueOf<typeof LensVisualizationType>]: ChartType;
 };
 const lensTypesToChartTypes: LensToChartMap = {
-  [LensVisualizationType.XY]: ChartType.XY,
-  [LensVisualizationType.Metric]: ChartType.Metric,
-  [LensVisualizationType.LegacyMetric]: ChartType.Metric,
-  [LensVisualizationType.Pie]: ChartType.Pie,
-  [LensVisualizationType.Heatmap]: ChartType.Heatmap,
-  [LensVisualizationType.Gauge]: ChartType.Gauge,
-  [LensVisualizationType.Datatable]: ChartType.Table,
+  [LensVisualizationType.lnsXY]: ChartType.XY,
+  [LensVisualizationType.lnsMetric]: ChartType.Metric,
+  [LensVisualizationType.lnsLegacyMetric]: ChartType.Metric,
+  [LensVisualizationType.lnsPie]: ChartType.Pie,
+  [LensVisualizationType.lnsHeatmap]: ChartType.Heatmap,
+  [LensVisualizationType.lnsGauge]: ChartType.Gauge,
+  [LensVisualizationType.lnsDatatable]: ChartType.Table,
 };
 function isLensVisualizationType(value: string): value is LensVisualizationType {
   return value in LensVisualizationType;

diff --git a/packages/kbn-visualization-utils/src/types.ts b/packages/kbn-visualization-utils/src/types.ts
@@ -62,11 +62,11 @@ export enum ChartType {
 }
 
 export enum LensVisualizationType {
-  XY = 'lnsXY',
-  Metric = 'lnsMetric',
-  Pie = 'lnsPie',
-  Heatmap = 'lnsHeatmap',
-  Gauge = 'lnsGauge',
-  Datatable = 'lnsDatatable',
-  LegacyMetric = 'lnsLegacyMetric',
+  lnsXY = 'lnsXY',
+  lnsMetric = 'lnsMetric',
+  lnsPie = 'lnsPie',
+  lnsHeatmap = 'lnsHeatmap',
+  lnsGauge = 'lnsGauge',
+  lnsDatatable = 'lnsDatatable',
+  lnsLegacyMetric = 'lnsLegacyMetric',
 }
diff --git a/x-pack/plugins/lens/public/lens_suggestions_api/helpers.ts b/x-pack/plugins/lens/public/lens_suggestions_api/helpers.ts
@@ -65,7 +65,11 @@ export function mergeSuggestionWithVisContext({
       keptLayerIds: layerIds,
       datasourceState,
       datasourceId,
-    } as Suggestion;
+      columns: suggestion.columns,
+      changeType: suggestion.changeType,
+      score: suggestion.score,
+      previewIcon: suggestion.previewIcon,
+    };
   } catch {
     return suggestion;
   }