Skip to content

Commit

Permalink
Remove Sass @euiPanel mixin usage (#194646)
Browse files Browse the repository at this point in the history
## Summary

This PR is part of EUI's ongoing Emotion migration. We are actively
deprecating/removing Sass mixins and variables that are
component-specific.

In this case, the `@mixin euiPanel` **only** sets `flex-grow: 1;` as its
default CSS and creates a bunch of modifier classes, none of which were
being used in Kibana - hence various removals (see git commits for more
specifics).

### QA

- [x] Checked Search Profiler for visual regressions
- [x] Checked Visualize Library > TSVB for visual regressions

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
  • Loading branch information
cee-chen authored Oct 2, 2024
1 parent b61bb95 commit cf72f3e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
background-color: $euiColorLightestShade;
}

@include euiPanel('.tvbAnnotationsEditor');

.tvbAnnotationsEditor {
margin-bottom: $euiSize;
padding: $euiSizeS;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
padding: $euiSize;
}

@include euiPanel('.tvbSeriesEditor');

.tvbSeriesEditor {
margin-bottom: $euiSize;
padding: $euiSizeS;
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/searchprofiler/public/application/_app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ $bodyOffset: $euiSize * 3;

.prfDevTool__main {
height: 100%;
flex-grow: 1;
order: 2;
margin-left: $euiSize;
display: flex;
Expand All @@ -49,8 +50,6 @@ $bodyOffset: $euiSize * 3;
}
}

@include euiPanel('.prfDevTool__main');

@include euiBreakpoint('xs', 's') {
.prfDevTool__container {
flex-direction: column;
Expand Down

0 comments on commit cf72f3e

Please sign in to comment.