Skip to content

Commit

Permalink
Addressed comments around errors and burn number
Browse files Browse the repository at this point in the history
  • Loading branch information
dkirchan committed Nov 3, 2023
1 parent 691d8c7 commit d25ab4e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ async function createEnvironment(
product: response.data.type,
};
} catch (error) {
log.error(`${error}`);
if (error instanceof AxiosError) {
log.error(`${error.response?.status}:${error.response?.data}`);
} else {
log.error(`${error.message}`);
}
}
}

Expand All @@ -121,7 +125,11 @@ async function deleteEnvironment(
});
log.info(`Environment ${projectName} was successfully deleted!`);
} catch (error) {
log.error(`${error}`);
if (error instanceof AxiosError) {
log.error(`${error.response?.status}:${error.response?.data}`);
} else {
log.error(`${error.message}`);
}
}
}

Expand All @@ -147,7 +155,7 @@ async function resetCredentials(
username: response.data.username,
};
} catch (error) {
throw new Error(`${error}`);
throw new Error(`${error.message}`);
}
}

Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/security_solution_cypress/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"cypress:investigations:run:serverless": "yarn cypress:serverless --spec './cypress/e2e/investigations/**/*.cy.ts'",
"cypress:explore:run:serverless": "yarn cypress:serverless --spec './cypress/e2e/explore/**/*.cy.ts'",
"cypress:changed-specs-only:serverless": "yarn cypress:serverless --changed-specs-only --env burn=5",
"cypress:burn:serverless": "yarn cypress:serverless --env burn=5",
"cypress:burn:serverless": "yarn cypress:serverless --env burn=2",
"cypress:run:qa:serverless:parallel": "TZ=UTC NODE_OPTIONS=--openssl-legacy-provider node ../../plugins/security_solution/scripts/start_cypress_parallel_serverless --config-file ../../test/security_solution_cypress/cypress/cypress_ci_serverless_qa.config.ts"
}
}

0 comments on commit d25ab4e

Please sign in to comment.