review III

x-pack/legacy/plugins/siem/public/components/empty_page/index.tsx

@@ -46,8 +46,8 @@ export const EmptyPage = React.memo<EmptyPageProps>(
       title={<h2>{title}</h2>}
       body={message && <p>{message}</p>}
       actions={
-        <EuiFlexGroup>
-          <EuiFlexItem>
+        <EuiFlexGroup justifyContent="center">
+          <EuiFlexItem grow={false}>
             <EuiButton
               fill
               href={actionPrimaryUrl}
@@ -59,7 +59,7 @@ export const EmptyPage = React.memo<EmptyPageProps>(
           </EuiFlexItem>
 
           {actionSecondaryLabel && actionSecondaryUrl && (
-            <EuiFlexItem>
+            <EuiFlexItem grow={false}>
               <EuiButton
                 href={actionSecondaryUrl}
                 iconType={actionSecondaryIcon}

x-pack/legacy/plugins/siem/public/components/ml/api/throw_if_not_ok.ts

@@ -10,11 +10,7 @@ import * as i18n from './translations';
 import { MlError } from '../types';
 import { SetupMlResponse } from '../../ml_popover/types';
 
-export interface MessageBody {
-  error?: string;
-  message?: string;
-  statusCode?: number;
-}
+export { MessageBody, parseJsonFromBody } from '../../../utils/api';
 
 export interface MlStartJobError {
   error: MlError;
@@ -35,15 +31,6 @@ export class ToasterErrors extends Error implements ToasterErrorsType {
   }
 }
 
-export const parseJsonFromBody = async (response: Response): Promise<MessageBody | null> => {
-  try {
-    const text = await response.text();
-    return JSON.parse(text);
-  } catch (error) {
-    return null;
-  }
-};
-
 export const tryParseResponse = (response: string): string => {
   try {
     return JSON.stringify(JSON.parse(response), null, 2);

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/api.ts

@@ -23,13 +23,14 @@ import {
   PostSignalError,
   BasicSignals,
 } from './types';
-import { parseJsonFromBody } from '../../../components/ml/api/throw_if_not_ok';
+import { parseJsonFromBody } from '../../../utils/api';
 
 /**
  * Fetch Signals by providing a query
  *
  * @param query String to match a dsl
  * @param kbnVersion current Kibana Version to use for headers
+ * @param signal AbortSignal for cancelling request
  */
 export const fetchQuerySignals = async <Hit, Aggregations>({
   query,
@@ -58,7 +59,7 @@ export const fetchQuerySignals = async <Hit, Aggregations>({
  * @param query of signals to update
  * @param status to update to('open' / 'closed')
  * @param kbnVersion current Kibana Version to use for headers
- * @param signal to cancel request
+ * @param signal AbortSignal for cancelling request
  */
 export const updateSignalStatus = async ({
   query,
@@ -86,6 +87,7 @@ export const updateSignalStatus = async ({
  * Fetch Signal Index
  *
  * @param kbnVersion current Kibana Version to use for headers
+ * @param signal AbortSignal for cancelling request
  */
 export const getSignalIndex = async ({
   kbnVersion,
@@ -116,6 +118,7 @@ export const getSignalIndex = async ({
  * Get User Privileges
  *
  * @param kbnVersion current Kibana Version to use for headers
+ * @param signal AbortSignal for cancelling request
  */
 export const getUserPrivilege = async ({
   kbnVersion,
@@ -140,6 +143,7 @@ export const getUserPrivilege = async ({
  * Create Signal Index if needed it
  *
  * @param kbnVersion current Kibana Version to use for headers
+ * @param signal AbortSignal for cancelling request
  */
 export const createSignalIndex = async ({
   kbnVersion,

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/errors_types/get_index_error.ts

@@ -16,6 +16,7 @@ export class SignalIndexError extends Error {
     this.message = errObj.message ?? '';
     this.statusCode = errObj.statusCode ?? -1;
     this.error = errObj.error ?? '';
+    this.name = 'SignalIndexError';
 
     // Set the prototype explicitly.
     Object.setPrototypeOf(this, SignalIndexError.prototype);

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/errors_types/post_index_error.ts

@@ -16,6 +16,7 @@ export class PostSignalError extends Error {
     this.message = errObj.message ?? '';
     this.statusCode = errObj.statusCode ?? -1;
     this.error = errObj.error ?? '';
+    this.name = 'PostSignalError';
 
     // Set the prototype explicitly.
     Object.setPrototypeOf(this, PostSignalError.prototype);

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/errors_types/privilege_user_error.ts

@@ -16,6 +16,7 @@ export class PrivilegeUserError extends Error {
     this.message = errObj.message ?? '';
     this.statusCode = errObj.statusCode ?? -1;
     this.error = errObj.error ?? '';
+    this.name = 'PrivilegeUserError';
 
     // Set the prototype explicitly.
     Object.setPrototypeOf(this, PrivilegeUserError.prototype);

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/types.ts

@@ -43,14 +43,6 @@ export interface UpdateSignalStatusProps {
   signal?: AbortSignal; // TODO: implement cancelling
 }
 
-// export class PostSignalsError extends Error {
-//   constructor(m: string) {
-//     super(m);
-//     // Set the prototype explicitly.
-//     Object.setPrototypeOf(this, SignalsIndexError.prototype);
-//   }
-// }
-
 export interface SignalsIndex {
   name: string;
 }
@@ -105,5 +97,5 @@ export interface Privilege {
       write: boolean;
     };
   };
-  isAuthenticated: true;
+  isAuthenticated: boolean;
 }

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/use_privilege_user.tsx

@@ -15,8 +15,6 @@ type Return = [boolean, boolean | null, boolean | null];
 /**
  * Hook to get user privilege from
  *
- * @param query convert a dsl into string
- *
  */
 export const usePrivilegeUser = (): Return => {
   const [loading, setLoading] = useState(true);

x-pack/legacy/plugins/siem/public/utils/api/index.ts

@@ -0,0 +1,20 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+export interface MessageBody {
+  error?: string;
+  message?: string;
+  statusCode?: number;
+}
+
+export const parseJsonFromBody = async (response: Response): Promise<MessageBody | null> => {
+  try {
+    const text = await response.text();
+    return JSON.parse(text);
+  } catch (error) {
+    return null;
+  }
+};