fix type

elastic · Jan 17, 2020 · d58a473 · d58a473
1 parent aeddd3f
commit d58a473
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 16 deletions.
diff --git a/x-pack/legacy/plugins/siem/public/components/header_global/index.tsx b/x-pack/legacy/plugins/siem/public/components/header_global/index.tsx
@@ -55,7 +55,7 @@ export const HeaderGlobal = React.memo<HeaderGlobalProps>(({ hideDetectionEngine
                     display="condensed"
                     navTabs={
                       hideDetectionEngine
-                        ? pickBy((_, key) => key !== SiemPageName.detectionEngine, navTabs)
+                        ? pickBy((_, key) => key !== SiemPageName.detections, navTabs)
                         : navTabs
                     }
                   />

diff --git a/x-pack/legacy/plugins/siem/public/components/link_to/link_to.tsx b/x-pack/legacy/plugins/siem/public/components/link_to/link_to.tsx
@@ -60,26 +60,26 @@ export const LinkToPage = React.memo<LinkToPageProps>(({ match }) => (
     <Route
       component={RedirectToDetectionEnginePage}
       exact
-      path={`${match.url}/:pageName(${SiemPageName.detectionEngine})`}
+      path={`${match.url}/:pageName(${SiemPageName.detections})`}
       strict
     />
     <Route
       component={RedirectToRulesPage}
       exact
-      path={`${match.url}/:pageName(${SiemPageName.detectionEngine})/rules`}
+      path={`${match.url}/:pageName(${SiemPageName.detections})/rules`}
     />
     <Route
       component={RedirectToCreateRulePage}
-      path={`${match.url}/:pageName(${SiemPageName.detectionEngine})/rules/create-rule`}
+      path={`${match.url}/:pageName(${SiemPageName.detections})/rules/create-rule`}
     />
     <Route
       component={RedirectToRuleDetailsPage}
       exact
-      path={`${match.url}/:pageName(${SiemPageName.detectionEngine})/rules/rule-details`}
+      path={`${match.url}/:pageName(${SiemPageName.detections})/rules/rule-details`}
     />
     <Route
       component={RedirectToEditRulePage}
-      path={`${match.url}/:pageName(${SiemPageName.detectionEngine})/rules/rule-details/edit-rule`}
+      path={`${match.url}/:pageName(${SiemPageName.detections})/rules/rule-details/edit-rule`}
     />
     <Route
       component={RedirectToTimelinesPage}

diff --git a/x-pack/legacy/plugins/siem/public/components/url_state/helpers.ts b/x-pack/legacy/plugins/siem/public/components/url_state/helpers.ts
@@ -78,7 +78,7 @@ export const getUrlType = (pageName: string): UrlStateType => {
     return 'host';
   } else if (pageName === SiemPageName.network) {
     return 'network';
-  } else if (pageName === SiemPageName.detectionEngine) {
+  } else if (pageName === SiemPageName.detections) {
     return 'detections';
   } else if (pageName === SiemPageName.timelines) {
     return 'timeline';
@@ -111,8 +111,8 @@ export const getCurrentLocation = (
       return CONSTANTS.networkDetails;
     }
     return CONSTANTS.networkPage;
-  } else if (pageName === SiemPageName.detectionEngine) {
-    return CONSTANTS.detectionEnginePage;
+  } else if (pageName === SiemPageName.detections) {
+    return CONSTANTS.detectionsPage;
   } else if (pageName === SiemPageName.timelines) {
     return CONSTANTS.timelinePage;
   }
@@ -129,7 +129,8 @@ export const isKqlForRoute = (
     (currentLocation === CONSTANTS.hostsPage && queryLocation === CONSTANTS.hostsPage) ||
     (currentLocation === CONSTANTS.networkPage && queryLocation === CONSTANTS.networkPage) ||
     (currentLocation === CONSTANTS.hostsDetails && queryLocation === CONSTANTS.hostsDetails) ||
-    (currentLocation === CONSTANTS.networkDetails && queryLocation === CONSTANTS.networkDetails)
+    (currentLocation === CONSTANTS.networkDetails && queryLocation === CONSTANTS.networkDetails) ||
+    (currentLocation === CONSTANTS.detectionsPage && queryLocation === CONSTANTS.detectionsPage)
   ) {
     return true;
   }

diff --git a/x-pack/legacy/plugins/siem/public/components/url_state/types.ts b/x-pack/legacy/plugins/siem/public/components/url_state/types.ts
@@ -56,7 +56,7 @@ export const URL_STATE_KEYS: Record<UrlStateType, KeyUrlState[]> = {
 };
 
 export type LocationTypes =
-  | CONSTANTS.detectionEnginePage
+  | CONSTANTS.detectionsPage
   | CONSTANTS.hostsDetails
   | CONSTANTS.hostsPage
   | CONSTANTS.networkDetails

diff --git a/x-pack/legacy/plugins/siem/public/pages/home/home_navigations.tsx b/x-pack/legacy/plugins/siem/public/pages/home/home_navigations.tsx
@@ -36,8 +36,8 @@ export const navTabs: SiemNavTab = {
     disabled: false,
     urlKey: 'network',
   },
-  [SiemPageName.detectionEngine]: {
-    id: SiemPageName.detectionEngine,
+  [SiemPageName.detections]: {
+    id: SiemPageName.detections,
     name: i18n.DETECTION_ENGINE,
     href: getDetectionEngineUrl(),
     disabled: false,

diff --git a/x-pack/legacy/plugins/siem/public/pages/home/index.tsx b/x-pack/legacy/plugins/siem/public/pages/home/index.tsx
@@ -105,7 +105,7 @@ export const HomePage: React.FC = () => (
                     )}
                   />
                   <Route
-                    path={`/:pageName(${SiemPageName.detectionEngine})`}
+                    path={`/:pageName(${SiemPageName.detections})`}
                     render={({ location, match }) => (
                       <DetectionEngineContainer location={location} url={match.url} />
                     )}

diff --git a/x-pack/legacy/plugins/siem/public/pages/home/types.ts b/x-pack/legacy/plugins/siem/public/pages/home/types.ts
@@ -10,15 +10,15 @@ export enum SiemPageName {
   overview = 'overview',
   hosts = 'hosts',
   network = 'network',
-  detectionEngine = 'detections',
+  detections = 'detections',
   timelines = 'timelines',
 }
 
 export type SiemNavTabKey =
   | SiemPageName.overview
   | SiemPageName.hosts
   | SiemPageName.network
-  | SiemPageName.detectionEngine
+  | SiemPageName.detections
   | SiemPageName.timelines;
 
 export type SiemNavTab = Record<SiemNavTabKey, NavTab>;