-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add group-by feature in APM rules (#155001)
## Summary Adds group-by dropdown in the following APM rules. - APM Latency threshold (Preselected fields: `service.name`, `service.environment`, `transaction.type`) - APM Failed transaction rate (Preselected fields: `service.name`, `service.environment`, `transaction.type`) - APM Error count threshold (Preselected fields: `service.name`, `service.environment`) <img width="609" alt="Screenshot 2023-04-17 at 13 44 34" src="https://user-images.githubusercontent.com/69037875/232475262-41786edf-d16b-4b1f-90a9-8fe242a36bcc.png"> The preselected fields cannot be removed by user. The `transaction.name` field is selectable by user from the group-by dropdown. - #154535 - #154536 - #154537 Reason message is updated to include group key instead of only service name: - #155011 The `transaction.name` is added to the alert document: - #154543 The `transaction.name` action variable is added in UI: - #154545 The `transaction.name` is added to the context of active alert notifications: - #154547 There are additional fields in group-by dropdown for Error count threshold rule: #155633 - error.grouping_key - error.grouping_name ## Fixes - #154818 ### Update on Alert Id The alert Id is updated for all 3 rules. The new Id is generated from the group key. This is to avoid issues similar to #154818 where alerts are scheduled with same ID. Example of the new alert Ids - `opbeans-java_development_request_GET /flaky`, `opbeans-java_development_GET /fail` ## Out of scope of this PR - Updating the preview chart based on selected group by fields ## Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ## Release note As the alert Id is updated for the APM Latency threshold rule, APM Failed transaction rate rule and APM Error count rule, the existing alerts, if any, will be recovered, and new alerts will be fired in place of them. --------- Co-authored-by: Katerina Patticha <kate@kpatticha.com> Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
- Loading branch information
1 parent
2fad86a
commit ddd09ac
Showing
27 changed files
with
1,943 additions
and
176 deletions.
There are no files selected for viewing
12 changes: 6 additions & 6 deletions
12
x-pack/plugins/apm/common/es_fields/__snapshots__/es_fields.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.