Remove control group renderer from plugin. Export lazy control group …

…renderer from index
elastic · Oct 13, 2022 · e2dd6b4 · e2dd6b4
1 parent 8622f0d
commit e2dd6b4
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 6 deletions.
diff --git a/src/plugins/controls/public/control_group/control_group_renderer.tsx b/src/plugins/controls/public/control_group/control_group_renderer.tsx
@@ -7,7 +7,7 @@
  */
 
 import uuid from 'uuid';
-import { useLifecycles } from 'react-use/lib';
+import useLifecycles from 'react-use/lib/useLifecycles';
 import React, { useEffect, useMemo, useRef, useState } from 'react';
 
 import { IEmbeddable } from '@kbn/embeddable-plugin/public';
@@ -78,3 +78,7 @@ export const ControlGroupRenderer = ({ input, onEmbeddableLoad }: ControlGroupRe
 
   return <div ref={controlsRoot} />;
 };
+
+// required for dynamic import using React.lazy()
+// eslint-disable-next-line import/no-default-export
+export default ControlGroupRenderer;
diff --git a/src/plugins/controls/public/control_group/index.ts b/src/plugins/controls/public/control_group/index.ts
@@ -6,8 +6,13 @@
  * Side Public License, v 1.
  */
 
+import React from 'react';
+
 export type { ControlGroupContainer } from './embeddable/control_group_container';
 export type { ControlGroupInput, ControlGroupOutput } from './types';
 
 export { CONTROL_GROUP_TYPE } from './types';
 export { ControlGroupContainerFactory } from './embeddable/control_group_container_factory';
+
+export { ControlGroupRendererProps } from './control_group_renderer';
+export const LazyControlGroupRenderer = React.lazy(() => import('./control_group_renderer'));
diff --git a/src/plugins/controls/public/index.ts b/src/plugins/controls/public/index.ts
@@ -51,6 +51,7 @@ export {
 } from './range_slider';
 
 export { LazyControlsCallout, type CalloutProps } from './controls_callout';
+export { LazyControlGroupRenderer, type ControlGroupRendererProps } from './control_group';
 
 export function plugin() {
   return new ControlsPlugin();

diff --git a/src/plugins/controls/public/plugin.ts b/src/plugins/controls/public/plugin.ts
@@ -16,7 +16,6 @@ import {
   RANGE_SLIDER_CONTROL,
   TIME_SLIDER_CONTROL,
 } from '.';
-import { ControlGroupRenderer } from './control_group/control_group_renderer';
 import { OptionsListEmbeddableFactory, OptionsListEmbeddableInput } from './options_list';
 import { RangeSliderEmbeddableFactory, RangeSliderEmbeddableInput } from './range_slider';
 import { TimeSliderEmbeddableFactory, TimeSliderControlEmbeddableInput } from './time_slider';
@@ -121,7 +120,6 @@ export class ControlsPlugin
     return {
       getControlFactory,
       getControlTypes,
-      ControlGroupRenderer,
     };
   }
 

diff --git a/src/plugins/controls/public/services/plugin_services.stub.ts b/src/plugins/controls/public/services/plugin_services.stub.ts
@@ -47,6 +47,5 @@ export const getStubPluginServices = (): ControlsPluginStart => {
   return {
     getControlFactory: pluginServices.getServices().controls.getControlFactory,
     getControlTypes: pluginServices.getServices().controls.getControlTypes,
-    ControlGroupRenderer: jest.fn(),
   };
 };
diff --git a/src/plugins/controls/public/types.ts b/src/plugins/controls/public/types.ts
@@ -20,7 +20,6 @@ import { DataViewField, DataViewsPublicPluginStart } from '@kbn/data-views-plugi
 import { UnifiedSearchPublicPluginStart } from '@kbn/unified-search-plugin/public';
 import { ControlInput } from '../common/types';
 import { ControlsServiceType } from './services/controls/types';
-import { ControlGroupRendererProps } from './control_group/control_group_renderer';
 
 export interface CommonControlOutput {
   filters?: Filter[];
@@ -82,7 +81,6 @@ export interface ControlsPluginSetup {
 export interface ControlsPluginStart {
   getControlFactory: ControlsServiceType['getControlFactory'];
   getControlTypes: ControlsServiceType['getControlTypes'];
-  ControlGroupRenderer: React.FC<ControlGroupRendererProps>;
 }
 
 export interface ControlsPluginSetupDeps {