Pr feedback

elastic · May 12, 2022 · f20041d · f20041d
1 parent dfd636a
commit f20041d
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 40 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/authentication/helpers.tsx b/x-pack/plugins/security_solution/public/common/components/authentication/helpers.tsx
@@ -249,7 +249,7 @@ const SUCCESS_COLUMN: Columns<AuthenticationsEdges, AuthenticationsEdges> = {
           },
         }}
         isAggregatable={true}
-        fieldType={'keyword'}
+        fieldType="keyword"
         render={(dataProvider, _, snapshot) =>
           snapshot.isDragging ? (
             <DragEffects>

diff --git a/x-pack/plugins/security_solution/public/common/components/ml/score/draggable_score.tsx b/x-pack/plugins/security_solution/public/common/components/ml/score/draggable_score.tsx
@@ -70,7 +70,7 @@ export const DraggableScoreComponent = ({
       dataProvider={dataProviderProp}
       render={render}
       isAggregatable={true}
-      fieldType={'keyword'}
+      fieldType="keyword"
     />
   );
 };

diff --git a/...ins/security_solution/public/common/components/tables/__snapshots__/helpers.test.tsx.snap b/...ins/security_solution/public/common/components/tables/__snapshots__/helpers.test.tsx.snap
diff --git a/x-pack/plugins/security_solution/public/common/components/tables/helpers.tsx b/x-pack/plugins/security_solution/public/common/components/tables/helpers.tsx
@@ -47,8 +47,8 @@ export const getRowItemDraggable = ({
   rowItem,
   attrName,
   idPrefix,
-  fieldType = 'keyword',
-  isAggregatable = false,
+  fieldType,
+  isAggregatable,
   render,
   dragDisplayValue,
 }: GetRowItemDraggableParams): JSX.Element => {

diff --git a/x-pack/plugins/security_solution/public/timelines/components/timeline/body/events/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/timeline/body/events/index.tsx
@@ -72,39 +72,37 @@ const EventsComponent: React.FC<Props> = ({
   tabType,
   leadingControlColumns,
   trailingControlColumns,
-}) => {
-  return (
-    <EventsTbody data-test-subj="events">
-      {data.map((event, i) => (
-        <StatefulEvent
-          actionsColumnWidth={actionsColumnWidth}
-          ariaRowindex={i + ARIA_ROW_INDEX_OFFSET}
-          columnHeaders={columnHeaders}
-          containerRef={containerRef}
-          event={event}
-          eventIdToNoteIds={eventIdToNoteIds}
-          isEventPinned={eventIsPinned({ eventId: event._id, pinnedEventIds })}
-          isEventViewer={isEventViewer}
-          key={`${id}_${tabType}_${event._id}_${event._index}_${
-            !isEmpty(event.ecs.eql?.sequenceNumber) ? event.ecs.eql?.sequenceNumber : ''
-          }`}
-          lastFocusedAriaColindex={lastFocusedAriaColindex}
-          loadingEventIds={loadingEventIds}
-          onRowSelected={onRowSelected}
-          renderCellValue={renderCellValue}
-          refetch={refetch}
-          rowRenderers={rowRenderers}
-          onRuleChange={onRuleChange}
-          selectedEventIds={selectedEventIds}
-          showCheckboxes={showCheckboxes}
-          tabType={tabType}
-          timelineId={id}
-          leadingControlColumns={leadingControlColumns}
-          trailingControlColumns={trailingControlColumns}
-        />
-      ))}
-    </EventsTbody>
-  );
-};
+}) => (
+  <EventsTbody data-test-subj="events">
+    {data.map((event, i) => (
+      <StatefulEvent
+        actionsColumnWidth={actionsColumnWidth}
+        ariaRowindex={i + ARIA_ROW_INDEX_OFFSET}
+        columnHeaders={columnHeaders}
+        containerRef={containerRef}
+        event={event}
+        eventIdToNoteIds={eventIdToNoteIds}
+        isEventPinned={eventIsPinned({ eventId: event._id, pinnedEventIds })}
+        isEventViewer={isEventViewer}
+        key={`${id}_${tabType}_${event._id}_${event._index}_${
+          !isEmpty(event.ecs.eql?.sequenceNumber) ? event.ecs.eql?.sequenceNumber : ''
+        }`}
+        lastFocusedAriaColindex={lastFocusedAriaColindex}
+        loadingEventIds={loadingEventIds}
+        onRowSelected={onRowSelected}
+        renderCellValue={renderCellValue}
+        refetch={refetch}
+        rowRenderers={rowRenderers}
+        onRuleChange={onRuleChange}
+        selectedEventIds={selectedEventIds}
+        showCheckboxes={showCheckboxes}
+        tabType={tabType}
+        timelineId={id}
+        leadingControlColumns={leadingControlColumns}
+        trailingControlColumns={trailingControlColumns}
+      />
+    ))}
+  </EventsTbody>
+);
 
 export const Events = React.memo(EventsComponent);