Fixing overlooked i18n translations

elastic · May 14, 2020 · fe12490 · fe12490
1 parent 2100a2f
commit fe12490
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/...gins/infra/public/pages/metrics/inventory_view/components/waffle/metric_control/index.tsx b/...gins/infra/public/pages/metrics/inventory_view/components/waffle/metric_control/index.tsx
@@ -132,7 +132,10 @@ export const WaffleMetricControls = ({
   }
 
   const button = (
-    <DropdownButton onClick={handleToggle} label="Metric">
+    <DropdownButton
+      onClick={handleToggle}
+      label={i18n.translate('xpack.infra.waffle.metriclabel', { defaultMessage: 'Metric' })}
+    >
       {currentLabel}
     </DropdownButton>
   );

diff --git a/.../infra/public/pages/metrics/inventory_view/components/waffle/waffle_group_by_controls.tsx b/.../infra/public/pages/metrics/inventory_view/components/waffle/waffle_group_by_controls.tsx
@@ -130,7 +130,10 @@ export const WaffleGroupByControls = class extends React.PureComponent<Props, St
       );
 
     const button = (
-      <DropdownButton label="Group By" onClick={this.handleToggle}>
+      <DropdownButton
+        label={i18n.translate('xpack.infra.waffle.groupByLabel', { defaultMessage: 'Group by' })}
+        onClick={this.handleToggle}
+      >
         {buttonBody}
       </DropdownButton>
     );

diff --git a/...infra/public/pages/metrics/inventory_view/components/waffle/waffle_inventory_switcher.tsx b/...infra/public/pages/metrics/inventory_view/components/waffle/waffle_inventory_switcher.tsx
@@ -7,6 +7,7 @@
 import { EuiPopover, EuiContextMenu, EuiContextMenuPanelDescriptor } from '@elastic/eui';
 
 import React, { useCallback, useState, useMemo } from 'react';
+import { i18n } from '@kbn/i18n';
 import { findInventoryModel } from '../../../../../../common/inventory_models';
 import { InventoryItemType } from '../../../../../../common/inventory_models/types';
 import { useWaffleOptionsContext } from '../../hooks/use_waffle_options';
@@ -115,7 +116,10 @@ export const WaffleInventorySwitcher: React.FC = () => {
   }, [nodeType]);
 
   const button = (
-    <DropdownButton onClick={openPopover} label="Show">
+    <DropdownButton
+      onClick={openPopover}
+      label={i18n.translate('xpack.infra.waffle.showLabel', { defaultMessage: 'Show' })}
+    >
       {selectedText}
     </DropdownButton>
   );

diff --git a/...ns/infra/public/pages/metrics/inventory_view/components/waffle/waffle_region_controls.tsx b/...ns/infra/public/pages/metrics/inventory_view/components/waffle/waffle_region_controls.tsx
@@ -57,7 +57,10 @@ export const WaffleRegionControls = (props: Props) => {
   );
 
   const button = (
-    <DropdownButton onClick={showPopover} label="Region">
+    <DropdownButton
+      onClick={showPopover}
+      label={i18n.translate('xpack.infra.waffle.regionLabel', { defaultMessage: 'Region' })}
+    >
       {currentLabel ||
         i18n.translate('xpack.infra.waffle.region', {
           defaultMessage: 'All',