Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Mosaic / mekko vis type #104223

Closed
Tracked by #57707
ghudgins opened this issue Jul 1, 2021 · 7 comments · Fixed by #117668
Closed
Tracked by #57707

[Lens] Mosaic / mekko vis type #104223

ghudgins opened this issue Jul 1, 2021 · 7 comments · Fixed by #117668
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ghudgins
Copy link
Contributor

ghudgins commented Jul 1, 2021

Describe the feature:
Expose mosaic from charts in Lens for all the great reasons in the charts PR: elastic/elastic-charts#1113

Describe a specific use case for the feature:
(from the charts PR)

Mosaic plots are often preferred over full, two-layer sunburst such as this. If the secondary partitioning is shared, eg. here, browsers, then sideways comparison is way more feasible than in the case of sunburst or treemap. In this case, the browser order should be shared too.

Mosaic plot is Lens friendly: it works with full-depth partitioning.

@ghudgins ghudgins added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

flash1293 commented Jul 5, 2021

This seems like an easy addition because it's similar enough to the existing partition charts we can make it a sub visualization type of the pie visualization (little additional work).

Another option would be to make this a setting for the existing "tree map" visualization type - is it different enough to warrant a new "chart type"?

@ghudgins
Copy link
Contributor Author

ghudgins commented Jul 6, 2021

I see them as 2 distinct chart types but @markov00 & @monfera & @MichaelMarcialis should weigh in when they have time

@ghudgins
Copy link
Contributor Author

ghudgins commented Jul 7, 2021

discussed briefly in datavis weekly and in the current lens chart type paradigm it makes most sense as its own type until such time we decide to collapse the number of types to just partition (treemap / pie / mosaic)

edit: nevermind the data vis catalog defines it as its own type so we should probably follow that https://datavizcatalogue.com/methods/marimekko_chart.html

@ghudgins
Copy link
Contributor Author

few extra details after talking with @elastic/datavis:

  • Mosaic should always have 2 "Group by"
  • because of the 2 group by requirement I don't think mosaic should be higher than treemap which is more flexible (but i'm going to add to our "suggestions meta" the idea that if there are two we should bump mosaic in priority)

@alexwizp alexwizp self-assigned this Oct 27, 2021
@MichaelMarcialis
Copy link
Contributor

In preparation for this feature, I've created a new icon for the mosaic visualization type to be used in the Lens app. Please download here.

alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 8, 2021
@ghudgins
Copy link
Contributor Author

@alexwizp I confirmed with @markov00 that we do need to put "Experimental" on this as kibana will be the first consumer of this functionality CC @flash1293

alexwizp added a commit that referenced this issue Nov 22, 2021
* [Lens] Mosaic / mekko vis type

Closes: #104223

* some updates

* fix color palette logic

* fix suggestions

* fix JEST

* fix some parts

* update labels

* Fix JEST

* add showExperimentalBadge

* add sorting

* fix toolbar options

* fix Marco suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dmlemeshko pushed a commit that referenced this issue Nov 29, 2021
* [Lens] Mosaic / mekko vis type

Closes: #104223

* some updates

* fix color palette logic

* fix suggestions

* fix JEST

* fix some parts

* update labels

* Fix JEST

* add showExperimentalBadge

* add sorting

* fix toolbar options

* fix Marco suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
TinLe pushed a commit to TinLe/kibana that referenced this issue Dec 22, 2021
* [Lens] Mosaic / mekko vis type

Closes: elastic#104223

* some updates

* fix color palette logic

* fix suggestions

* fix JEST

* fix some parts

* update labels

* Fix JEST

* add showExperimentalBadge

* add sorting

* fix toolbar options

* fix Marco suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants