Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Review Full Screen mode for Data Grid in Discover #109831

Closed
ryankeairns opened this issue Aug 24, 2021 · 3 comments
Closed

[Discover] Review Full Screen mode for Data Grid in Discover #109831

ryankeairns opened this issue Aug 24, 2021 · 3 comments
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@ryankeairns
Copy link
Contributor

After reviewing the EUI data grid bugs, we noted several originated from the Full Screen view. While none were considered blockers, it would be good to review this area more thoroughly as it is often overlooked in testing.
@ryankeairns ryankeairns added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 24, 2021
@ryankeairns ryankeairns added this to the Discover - New table by default milestone Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ryankeairns ryankeairns mentioned this issue Aug 24, 2021
Closed
41 tasks
@ryankeairns ryankeairns changed the title [Discover] Audit Full Screen mode for Data Grid in Discover [Discover] Review Full Screen mode for Data Grid in Discover Aug 24, 2021
@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal
Copy link
Member

kertal commented Jan 18, 2022

I've tested in Safari, Firefox, Chrome, and found a minor issue using Dashboards in edit mode: #123196

@ryankeairns
Copy link
Contributor Author

I'll mark this as closed as it was merely a reminder to do a review. I have tested the full screen mode on the a-la-carte instance and did not notice any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryankeairns @kertal @timroes @elasticmachine